chrome/browser/history/android/sqlite_cursor_unittest.cc - Issue 56143002: Make FaviconService() use Porfile as parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/android/sqlite_cursor_unittest.cc

Issue 56143002: Make FaviconService() use Porfile as parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix unit test but break the DEPS Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/android/sqlite_cursor_unittest.cc

diff --git a/chrome/browser/history/android/sqlite_cursor_unittest.cc b/chrome/browser/history/android/sqlite_cursor_unittest.cc

index ccca02ab5b3c04159dfe03cd8047274923a44f72..46f0f00567f89ccb78efa6ffde18dfdf8f12408d 100644

--- a/chrome/browser/history/android/sqlite_cursor_unittest.cc

+++ b/chrome/browser/history/android/sqlite_cursor_unittest.cc

@@ -195,7 +195,7 @@ TEST_F(SQLiteCursorTest, Run) {

column_names.push_back(HistoryAndBookmarkRow::GetAndroidName(

HistoryAndBookmarkRow::FAVICON));

- FaviconService* favicon_service = new FaviconService(hs_);

+ FaviconService* favicon_service = new FaviconService(testing_profile_);

SQLiteCursor* cursor = new SQLiteCursor(column_names, statement,

service_.get(), favicon_service);

« no previous file with comments | « chrome/browser/favicon/favicon_service_factory.cc ('k') | chrome/browser/jumplist_win.cc » ('j') | no next file with comments »