chrome/browser/favicon/favicon_service_factory.cc - Issue 56143002: Make FaviconService() use Porfile as parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_service_factory.cc

Issue 56143002: Make FaviconService() use Porfile as parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove scope_ptr Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/favicon/favicon_service_factory.cc

diff --git a/chrome/browser/favicon/favicon_service_factory.cc b/chrome/browser/favicon/favicon_service_factory.cc

index fce9098ec13affd4d053ebbd5754cbb2936bf773..4a2ed7e75593eb7dae105277b0fe7b63e9e78966 100644

--- a/chrome/browser/favicon/favicon_service_factory.cc

+++ b/chrome/browser/favicon/favicon_service_factory.cc

@@ -46,9 +46,7 @@ FaviconServiceFactory::~FaviconServiceFactory() {}

BrowserContextKeyedService* FaviconServiceFactory::BuildServiceInstanceFor(

content::BrowserContext* profile) const {

- HistoryService* history_service = HistoryServiceFactory::GetForProfile(

- static_cast<Profile*>(profile), Profile::EXPLICIT_ACCESS);

- return new FaviconService(history_service);

+ return new FaviconService(static_cast<Profile*>(profile));

}

bool FaviconServiceFactory::ServiceIsNULLWhileTesting() const {