Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1830)

Unified Diff: chrome/browser/favicon/favicon_service.h

Issue 56143002: Make FaviconService() use Porfile as parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove scope_ptr Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/favicon/favicon_service.h
diff --git a/chrome/browser/favicon/favicon_service.h b/chrome/browser/favicon/favicon_service.h
index ed1bc3d249530c8c511cd3dbd45d4e6279ec072c..8ec0846c666b70753687bf953d7fa47062d4aa0e 100644
--- a/chrome/browser/favicon/favicon_service.h
+++ b/chrome/browser/favicon/favicon_service.h
@@ -34,22 +34,19 @@ struct FaviconImageResult;
class FaviconService : public CancelableRequestProvider,
public BrowserContextKeyedService {
public:
- explicit FaviconService(HistoryService* history_service);
+ explicit FaviconService(Profile* profile);
virtual ~FaviconService();
// Auxiliary argument structure for requesting favicons for URLs.
struct FaviconForURLParams {
- FaviconForURLParams(Profile* profile,
- const GURL& page_url,
+ FaviconForURLParams(const GURL& page_url,
int icon_types,
int desired_size_in_dip)
- : profile(profile),
- page_url(page_url),
+ : page_url(page_url),
icon_types(icon_types),
desired_size_in_dip(desired_size_in_dip) {}
- Profile* profile;
GURL page_url;
int icon_types;
int desired_size_in_dip;
@@ -244,6 +241,7 @@ class FaviconService : public CancelableRequestProvider,
typedef uint32 MissingFaviconURLHash;
base::hash_set<MissingFaviconURLHash> missing_favicon_urls_;
HistoryService* history_service_;
+ Profile* profile_;
// Helper function for GetFaviconImageForURL(), GetRawFaviconForURL() and
// GetFaviconForURL().

Powered by Google App Engine
This is Rietveld 408576698