Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 561413002: [Invalidation tracking] Add trace events for layout invalidations (Closed)

Created:
6 years, 3 months ago by pdr.
Modified:
6 years, 3 months ago
Reviewers:
caseq, kouhei (in TOK)
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, aandrey+blink_chromium.org, rune+blink, vsevik+blink_chromium.org, caseq+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, abarth-chromium, jchaffraix+rendering, devtools-reviews_chromium.org, loislo+blink_chromium.org, zoltan1, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, blink-reviews-rendering, leviw+renderwatch, blink-layers+watch_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[Invalidation tracking] Add trace events for layout invalidations This patch adds trace events for setNeedsLayout calls so that we can do end-to-end tracking of what causes repaints to occur. The devtools side isn't yet hooked up so this patch simply adds the trace event. As a cleanup, "core/inspector/InspectorTraceEvents.h" has been moved up into RenderObject and unneeded includes have been removed. R=kouhei BUG=410701 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181865

Patch Set 1 #

Patch Set 2 : Add a static for callstack frame count #

Patch Set 3 : Constification #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M Source/core/inspector/InspectorTraceEvents.h View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorTraceEvents.cpp View 1 2 3 chunks +18 lines, -1 line 0 comments Download
M Source/core/rendering/RenderImage.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderObject.h View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
pdr.
6 years, 3 months ago (2014-09-11 22:25:48 UTC) #2
kouhei (in TOK)
lgtm Optional Nit: You might want to mention in description that "core/inspector/InspectorTraceEvents.h" include moved up ...
6 years, 3 months ago (2014-09-11 22:43:54 UTC) #3
pdr.
On 2014/09/11 22:43:54, kouhei wrote: > lgtm > > Optional Nit: You might want to ...
6 years, 3 months ago (2014-09-11 23:15:58 UTC) #4
kouhei (in TOK)
On 2014/09/11 23:15:58, pdr wrote: > On 2014/09/11 22:43:54, kouhei wrote: > > lgtm > ...
6 years, 3 months ago (2014-09-11 23:21:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/561413002/40001
6 years, 3 months ago (2014-09-11 23:26:36 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 01:03:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 181865

Powered by Google App Engine
This is Rietveld 408576698