Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 561383002: Use KURL when constructing ResourceRequest (Closed)

Created:
6 years, 3 months ago by rwlbuis
Modified:
6 years, 3 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use KURL when constructing ResourceRequest Instead of passing a String url and having ResourceRequest create a KURL out of it, pass in the readily available KURL object. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/svg/SVGUseElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL. I don't know KURL/ResourceRequest well enough but I think we were doing too much ...
6 years, 3 months ago (2014-09-11 22:02:24 UTC) #2
Nate Chapin
Agreed. LGTM
6 years, 3 months ago (2014-09-11 22:04:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/561383002/1
6 years, 3 months ago (2014-09-11 22:05:00 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 00:44:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181862

Powered by Google App Engine
This is Rietveld 408576698