Adding unit tests for the SafeBrowsingBlockingPage class

chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
===================================================================
--- chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc	(revision 0)
+++ chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc	(revision 0)
@@ -0,0 +1,355 @@
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/renderer_host/test_render_view_host.h"
+
+#include "chrome/browser/safe_browsing/safe_browsing_blocking_page.h"
+#include "chrome/browser/tab_contents/navigation_entry.h"
+#include "chrome/common/render_messages.h"
+
+static const char* kGoogleURL = "http://www.google.com/";
+static const char* kGoodURL = "http://www.goodguys.com/";
+static const char* kBadURL = "http://www.badguys.com/";
+static const char* kBadURL2 = "http://www.badguys2.com/";
+static const char* kBadURL3 = "http://www.badguys3.com/";
+
+static void InitNavigateParams(ViewHostMsg_FrameNavigate_Params* params,
+                               int page_id,
+                               const GURL& url) {
+  params->page_id = page_id;
+  params->url = url;
+  params->referrer = GURL::EmptyGURL();
+  params->transition = PageTransition::TYPED;
+  params->redirects = std::vector<GURL>();
+  params->should_update_history = false;
+  params->searchable_form_url = GURL::EmptyGURL();
+  params->searchable_form_element_name = std::wstring();
+  params->searchable_form_encoding = std::string();
+  params->password_form = PasswordForm();
+  params->security_info = std::string();
+  params->gesture = NavigationGestureUser;
+  params->is_post = false;
+}
+
+// A SafeBrowingBlockingPage class that does not create windows.
+class TestSafeBrowsingBlockingPage :  public SafeBrowsingBlockingPage {
+ public:
+  TestSafeBrowsingBlockingPage(SafeBrowsingService* service,
+                               WebContents* web_contents,
+                               const UnsafeResourceList& unsafe_resources)
+      : SafeBrowsingBlockingPage(service, web_contents, unsafe_resources) {
+  }
+
+  // Overriden from InterstitialPage.  Don't create a view.
+  virtual WebContentsView* CreateWebContentsView() {
+    return NULL;
+  }
+};
+
+class TestSafeBrowsingBlockingPageFactory
+    : public SafeBrowsingBlockingPageFactory {
+ public:
+  TestSafeBrowsingBlockingPageFactory() { }
+  ~TestSafeBrowsingBlockingPageFactory() { }
+
+  virtual SafeBrowsingBlockingPage* CreateSafeBrowsingPage(
+      SafeBrowsingService* service,
+      WebContents* web_contents,
+      const SafeBrowsingBlockingPage::UnsafeResourceList& unsafe_resources) {
+    return new TestSafeBrowsingBlockingPage(service, web_contents,
+                                            unsafe_resources);
+  }
+};
+
+class SafeBrowsingBlockingPageTest : public RenderViewHostTestHarness,
+                                     public SafeBrowsingService::Client {
+ public:
+  // The decision the user made.
+  enum UserResponse {
+    PENDING,
+    OK,
+    CANCEL
+  };
+
+  SafeBrowsingBlockingPageTest() {
+    ResetUserResponse();
+    service_ = new SafeBrowsingService();
+  }
+
+  virtual void SetUp() {
+    RenderViewHostTestHarness::SetUp();
+    SafeBrowsingBlockingPage::RegisterFactory(&factory_);
+    ResetUserResponse();
+  }
+
+  // SafeBrowsingService::Client implementation.
+  virtual void OnUrlCheckResult(const GURL& url,
+                                SafeBrowsingService::UrlCheckResult result) {
+  }
+  virtual void OnBlockingPageComplete(bool proceed) {
+    if (proceed)
+      user_response_ = OK;
+    else
+      user_response_ = CANCEL;
+  }
+
+  void Navigate(const char* url, int page_id) {
+    ViewHostMsg_FrameNavigate_Params params;
+    InitNavigateParams(&params, page_id, GURL(url));
+    contents()->TestDidNavigate(contents_->render_view_host(), params);
+  }
+
+  void ShowInterstitial(ResourceType::Type resource_type,
+                        const char* url) {
+    SafeBrowsingService::UnsafeResource resource;
+    InitResource(&resource, resource_type, GURL(url));
+    SafeBrowsingBlockingPage::ShowBlockingPage(service_, resource);
+  }
+
+  // Returns the SafeBrowsingBlockingPage currently showing or NULL if none is
+  // showing.
+  SafeBrowsingBlockingPage* GetSafeBrowsingBlockingPage() {
+    InterstitialPage* interstitial =
+        InterstitialPage::GetInterstitialPage(contents_);
+    if (!interstitial)
+      return NULL;
+    return  static_cast<SafeBrowsingBlockingPage*>(interstitial);
+  }
+
+  UserResponse user_response() const { return user_response_; }
+  void ResetUserResponse() { user_response_ = PENDING; }
+
+  static void ProceedThroughInterstitial(
+      SafeBrowsingBlockingPage* sb_interstitial) {
+    sb_interstitial->Proceed();
+    // Proceed() posts a task to update the SafeBrowsingService::Client.
+    MessageLoop::current()->RunAllPending();
+  }
+
+  static void DontProceedThroughInterstitial(
+      SafeBrowsingBlockingPage* sb_interstitial) {
+    sb_interstitial->DontProceed();
+    // DontProceed() posts a task to update the SafeBrowsingService::Client.
+    MessageLoop::current()->RunAllPending();
+  }
+
+ private:
+  void InitResource(SafeBrowsingService::UnsafeResource* resource,
+                    ResourceType::Type resource_type,
+                    const GURL& url) {
+    resource->client = this;
+    resource->url = url;
+    resource->resource_type = resource_type;
+    resource->threat_type = SafeBrowsingService::URL_MALWARE;
+    resource->render_process_host_id = contents_->process()->pid();
+    resource->render_view_id = contents_->render_view_host()->routing_id();
+  }
+
+  UserResponse user_response_;
+  scoped_refptr<SafeBrowsingService> service_;
+  TestSafeBrowsingBlockingPageFactory factory_;
+};
+
+// Tests showing a blocking page for a malware page and not proceeding.
+TEST_F(SafeBrowsingBlockingPageTest, MalwarePageDontProceed) {
+  // Start a load.
+  controller()->LoadURL(GURL(kBadURL), GURL(), PageTransition::TYPED);
+
+  // Simulate the load causing a safe browsing interstitial to be shown.
+  ShowInterstitial(ResourceType::MAIN_FRAME, kBadURL);
+  SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();
+  ASSERT_TRUE(sb_interstitial);
+
+  // Simulate the user clicking "don't proceed".
+  DontProceedThroughInterstitial(sb_interstitial);
+
+  // The interstitial should be gone.
+  EXPECT_EQ(CANCEL, user_response());
+  EXPECT_FALSE(GetSafeBrowsingBlockingPage());
+
+  // We did not proceed, the pending entry should be gone.
+  EXPECT_FALSE(controller()->GetPendingEntry());
+}
+
+// Tests showing a blocking page for a malware page and then proceeding.
+TEST_F(SafeBrowsingBlockingPageTest, MalwarePageProceed) {
+  // Start a load.
+  controller()->LoadURL(GURL(kBadURL), GURL(), PageTransition::TYPED);
+
+  // Simulate the load causing a safe browsing interstitial to be shown.
+  ShowInterstitial(ResourceType::MAIN_FRAME, kBadURL);
+  SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();
+  ASSERT_TRUE(sb_interstitial);
+
+  // Simulate the user clicking "proceed".
+  ProceedThroughInterstitial(sb_interstitial);
+
+  // The interstitial is shown until the navigation commits.
+  ASSERT_TRUE(InterstitialPage::GetInterstitialPage(contents_));
+  // Commit the navigation.
+  Navigate(kBadURL, 1);
+  // The interstitial should be gone now.
+  ASSERT_FALSE(InterstitialPage::GetInterstitialPage(contents_));
+}
+
+// Tests showing a blocking page for a page that contains malware subresources
+// and not proceeding.
+TEST_F(SafeBrowsingBlockingPageTest, PageWithMalwareResourceDontProceed) {
+  // Navigate somewhere.
+  Navigate(kGoogleURL, 1);
+
+  // Navigate somewhere else.
+  Navigate(kGoodURL, 2);
+
+  // Simulate that page loading a bad-resource triggering an interstitial.
+  ShowInterstitial(ResourceType::SUB_RESOURCE, kBadURL);
+
+  SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();
+  ASSERT_TRUE(sb_interstitial);
+
+  // Simulate the user clicking "don't proceed".
+  DontProceedThroughInterstitial(sb_interstitial);
+  EXPECT_EQ(CANCEL, user_response());
+  EXPECT_FALSE(GetSafeBrowsingBlockingPage());
+
+  // We did not proceed, we should be back to the first page, the 2nd one should
+  // have been removed from the navigation controller.
+  ASSERT_EQ(1, controller()->GetEntryCount());
+  EXPECT_EQ(kGoogleURL, controller()->GetActiveEntry()->url().spec());
+}
+
+// Tests showing a blocking page for a page that contains malware subresources
+// and proceeding.
+TEST_F(SafeBrowsingBlockingPageTest, PageWithMalwareResourceProceed) {
+  // Navigate somewhere.
+  Navigate(kGoodURL, 1);
+
+  // Simulate that page loading a bad-resource triggering an interstitial.
+  ShowInterstitial(ResourceType::SUB_RESOURCE, kBadURL);
+
+  SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();
+  ASSERT_TRUE(sb_interstitial);
+
+  // Simulate the user clicking "proceed".
+  ProceedThroughInterstitial(sb_interstitial);
+  EXPECT_EQ(OK, user_response());
+  EXPECT_FALSE(GetSafeBrowsingBlockingPage());
+
+  // We did proceed, we should be back to showing the page.
+  ASSERT_EQ(1, controller()->GetEntryCount());
+  EXPECT_EQ(kGoodURL, controller()->GetActiveEntry()->url().spec());
+}
+
+// Tests showing a blocking page for a page that contains multiple malware
+// subresources and not proceeding.  This just tests that the extra malware
+// subresources (which trigger queued interstitial pages) do not break anything.
+TEST_F(SafeBrowsingBlockingPageTest,
+       PageWithMultipleMalwareResourceDontProceed) {
+  // Navigate somewhere.
+  Navigate(kGoogleURL, 1);
+
+  // Navigate somewhere else.
+  Navigate(kGoodURL, 2);
+
+  // Simulate that page loading a bad-resource triggering an interstitial.
+  ShowInterstitial(ResourceType::SUB_RESOURCE, kBadURL);
+
+  // More bad resources loading causing more interstitials. The new
+  // interstitials should be queued.
+  ShowInterstitial(ResourceType::SUB_RESOURCE, kBadURL2);
+  ShowInterstitial(ResourceType::SUB_RESOURCE, kBadURL3);
+
+  SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();
+  ASSERT_TRUE(sb_interstitial);
+
+  // Simulate the user clicking "don't proceed".
+  DontProceedThroughInterstitial(sb_interstitial);
+  EXPECT_EQ(CANCEL, user_response());
+  EXPECT_FALSE(GetSafeBrowsingBlockingPage());
+
+  // We did not proceed, we should be back to the first page, the 2nd one should
+  // have been removed from the navigation controller.
+  ASSERT_EQ(1, controller()->GetEntryCount());
+  EXPECT_EQ(kGoogleURL, controller()->GetActiveEntry()->url().spec());
+}
+
+// Tests showing a blocking page for a page that contains multiple malware
+// subresources and proceeding through the first interstitial, but not the next.
+TEST_F(SafeBrowsingBlockingPageTest,
+       PageWithMultipleMalwareResourceProceedThenDontProceed) {
+  // Navigate somewhere.
+  Navigate(kGoogleURL, 1);
+
+  // Navigate somewhere else.
+  Navigate(kGoodURL, 2);
+
+  // Simulate that page loading a bad-resource triggering an interstitial.
+  ShowInterstitial(ResourceType::SUB_RESOURCE, kBadURL);
+
+  // More bad resources loading causing more interstitials. The new
+  // interstitials should be queued.
+  ShowInterstitial(ResourceType::SUB_RESOURCE, kBadURL2);
+  ShowInterstitial(ResourceType::SUB_RESOURCE, kBadURL3);
+
+  SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();
+  ASSERT_TRUE(sb_interstitial);
+
+  // Proceed through the 1st interstitial.
+  ProceedThroughInterstitial(sb_interstitial);
+  EXPECT_EQ(OK, user_response());
+
+  ResetUserResponse();
+
+  // We should land to a 2nd interstitial (aggregating all the malware resources
+  // loaded while the 1st interstitial was showing).
+  sb_interstitial = GetSafeBrowsingBlockingPage();
+  ASSERT_TRUE(sb_interstitial);
+
+  // Don't proceed through the 2nd interstitial.
+  DontProceedThroughInterstitial(sb_interstitial);
+  EXPECT_EQ(CANCEL, user_response());
+  EXPECT_FALSE(GetSafeBrowsingBlockingPage());
+
+  // We did not proceed, we should be back to the first page, the 2nd one should
+  // have been removed from the navigation controller.
+  ASSERT_EQ(1, controller()->GetEntryCount());
+  EXPECT_EQ(kGoogleURL, controller()->GetActiveEntry()->url().spec());
+}
+
+// Tests showing a blocking page for a page that contains multiple malware
+// subresources and proceeding through the multiple interstitials.
+TEST_F(SafeBrowsingBlockingPageTest, PageWithMultipleMalwareResourceProceed) {
+  // Navigate somewhere else.
+  Navigate(kGoodURL, 1);
+
+  // Simulate that page loading a bad-resource triggering an interstitial.
+  ShowInterstitial(ResourceType::SUB_RESOURCE, kBadURL);
+
+  // More bad resources loading causing more interstitials. The new
+  // interstitials should be queued.
+  ShowInterstitial(ResourceType::SUB_RESOURCE, kBadURL2);
+  ShowInterstitial(ResourceType::SUB_RESOURCE, kBadURL3);
+
+  SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();
+  ASSERT_TRUE(sb_interstitial);
+
+  // Proceed through the 1st interstitial.
+  ProceedThroughInterstitial(sb_interstitial);
+  EXPECT_EQ(OK, user_response());
+
+  ResetUserResponse();
+
+  // We should land to a 2nd interstitial (aggregating all the malware resources
+  // loaded while the 1st interstitial was showing).
+  sb_interstitial = GetSafeBrowsingBlockingPage();
+  ASSERT_TRUE(sb_interstitial);
+
+  // Proceed through the 2nd interstitial.
+  ProceedThroughInterstitial(sb_interstitial);
+  EXPECT_EQ(OK, user_response());
+
+  // We did proceed, we should be back to the initial page.
+  ASSERT_EQ(1, controller()->GetEntryCount());
+  EXPECT_EQ(kGoodURL, controller()->GetActiveEntry()->url().spec());
+}