Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/copy_target_generator.cc

Issue 561273003: Add public deps to GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gn/action_target_generator.cc ('K') | « tools/gn/config_values_extractors_unittest.cc ('k') | tools/gn/function_toolchain.cc » ('j') | tools/gn/header_checker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/copy_target_generator.cc
diff --git a/tools/gn/copy_target_generator.cc b/tools/gn/copy_target_generator.cc
index 544ef5f20fe40c9ea4ca6b47f605a3db24b8ccca..994011e824e614e5bdb5660d1a501fe2af7d5c64 100644
--- a/tools/gn/copy_target_generator.cc
+++ b/tools/gn/copy_target_generator.cc
@@ -23,11 +23,9 @@ CopyTargetGenerator::~CopyTargetGenerator() {
void CopyTargetGenerator::DoRun() {
target_->set_output_type(Target::COPY_FILES);
- FillSources();
- if (err_->has_error())
+ if (!FillSources())
return;
- FillOutputs(true);
- if (err_->has_error())
+ if (!FillOutputs(true))
return;
if (target_->sources().empty()) {
« tools/gn/action_target_generator.cc ('K') | « tools/gn/config_values_extractors_unittest.cc ('k') | tools/gn/function_toolchain.cc » ('j') | tools/gn/header_checker.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698