Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/binary_target_generator.h

Issue 561273003: Add public deps to GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gn/action_target_generator.cc ('K') | « tools/gn/action_target_generator.cc ('k') | tools/gn/binary_target_generator.cc » ('j') | tools/gn/header_checker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/binary_target_generator.h
diff --git a/tools/gn/binary_target_generator.h b/tools/gn/binary_target_generator.h
index b11da0ab04c518549a40f0d4a79d214f8aad29cf..f101dc2292fa9f0f21f5ddb5d5810dfcc4816d32 100644
--- a/tools/gn/binary_target_generator.h
+++ b/tools/gn/binary_target_generator.h
@@ -23,11 +23,11 @@ class BinaryTargetGenerator : public TargetGenerator {
virtual void DoRun() OVERRIDE;
private:
- void FillCheckIncludes();
- void FillCompleteStaticLib();
- void FillOutputName();
- void FillOutputExtension();
- void FillAllowCircularIncludesFrom();
+ bool FillCheckIncludes();
+ bool FillCompleteStaticLib();
+ bool FillOutputName();
+ bool FillOutputExtension();
+ bool FillAllowCircularIncludesFrom();
Target::OutputType output_type_;
« tools/gn/action_target_generator.cc ('K') | « tools/gn/action_target_generator.cc ('k') | tools/gn/binary_target_generator.cc » ('j') | tools/gn/header_checker.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698