tools/gn/copy_target_generator.cc - Issue 561273003: Add public deps to GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/copy_target_generator.cc

Issue 561273003: Add public deps to GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/copy_target_generator.cc

diff --git a/tools/gn/copy_target_generator.cc b/tools/gn/copy_target_generator.cc

index 544ef5f20fe40c9ea4ca6b47f605a3db24b8ccca..994011e824e614e5bdb5660d1a501fe2af7d5c64 100644

--- a/tools/gn/copy_target_generator.cc

+++ b/tools/gn/copy_target_generator.cc

@@ -23,11 +23,9 @@ CopyTargetGenerator::~CopyTargetGenerator() {

void CopyTargetGenerator::DoRun() {

target_->set_output_type(Target::COPY_FILES);

- FillSources();

- if (err_->has_error())

+ if (!FillSources())

return;

- FillOutputs(true);

- if (err_->has_error())

+ if (!FillOutputs(true))

return;

if (target_->sources().empty()) {

« no previous file with comments | « tools/gn/config_values_extractors_unittest.cc ('k') | tools/gn/deps_iterator.h » ('j') | no next file with comments »