Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: tools/gn/target_generator.h

Issue 561273003: Add public deps to GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/target_generator.h
diff --git a/tools/gn/target_generator.h b/tools/gn/target_generator.h
index c09567065b18bff883cc45baa416e44d778b5d5c..c93b12b1c2e328081bc1c7f64e83359bdada5ea9 100644
--- a/tools/gn/target_generator.h
+++ b/tools/gn/target_generator.h
@@ -48,11 +48,11 @@ class TargetGenerator {
const BuildSettings* GetBuildSettings() const;
- void FillSources();
- void FillPublic();
- void FillInputs();
- void FillConfigs();
- void FillOutputs(bool allow_substitutions);
+ bool FillSources();
+ bool FillPublic();
+ bool FillInputs();
+ bool FillConfigs();
+ bool FillOutputs(bool allow_substitutions);
// Rrturns true if the given pattern will expand to a file in the output
// directory. If not, returns false and sets the error, blaming the given
@@ -67,18 +67,18 @@ class TargetGenerator {
Err* err_;
private:
- void FillDependentConfigs(); // Includes all types of dependent configs.
- void FillData();
- void FillDependencies(); // Includes data dependencies.
- void FillTestonly();
+ bool FillDependentConfigs(); // Includes all types of dependent configs.
+ bool FillData();
+ bool FillDependencies(); // Includes data dependencies.
+ bool FillTestonly();
// Reads configs/deps from the given var name, and uses the given setting on
// the target to save them.
- void FillGenericConfigs(const char* var_name,
+ bool FillGenericConfigs(const char* var_name,
UniqueVector<LabelConfigPair>* dest);
- void FillGenericDeps(const char* var_name, LabelTargetVector* dest);
+ bool FillGenericDeps(const char* var_name, LabelTargetVector* dest);
- void FillForwardDependentConfigs();
+ bool FillForwardDependentConfigs();
DISALLOW_COPY_AND_ASSIGN(TargetGenerator);
};
« tools/gn/target.cc ('K') | « tools/gn/target.cc ('k') | tools/gn/target_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698