Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: tools/gn/ninja_group_target_writer_unittest.cc

Issue 561273003: Add public deps to GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/ninja_group_target_writer_unittest.cc
diff --git a/tools/gn/ninja_group_target_writer_unittest.cc b/tools/gn/ninja_group_target_writer_unittest.cc
index 0aec35c5890354b003c6b2af6e92da1fbc9ed439..c9d0ab4553d80ecc99980e3d7adb2450515989ac 100644
--- a/tools/gn/ninja_group_target_writer_unittest.cc
+++ b/tools/gn/ninja_group_target_writer_unittest.cc
@@ -15,25 +15,29 @@ TEST(NinjaGroupTargetWriter, Run) {
Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));
target.set_output_type(Target::GROUP);
+ target.visibility().SetPublic();
Target dep(setup.settings(), Label(SourceDir("//foo/"), "dep"));
dep.set_output_type(Target::ACTION);
+ dep.visibility().SetPublic();
dep.SetToolchain(setup.toolchain());
ASSERT_TRUE(dep.OnResolved(&err));
Target dep2(setup.settings(), Label(SourceDir("//foo/"), "dep2"));
dep2.set_output_type(Target::ACTION);
+ dep2.visibility().SetPublic();
dep2.SetToolchain(setup.toolchain());
ASSERT_TRUE(dep2.OnResolved(&err));
Target datadep(setup.settings(), Label(SourceDir("//foo/"), "datadep"));
datadep.set_output_type(Target::ACTION);
+ datadep.visibility().SetPublic();
datadep.SetToolchain(setup.toolchain());
ASSERT_TRUE(datadep.OnResolved(&err));
- target.deps().push_back(LabelTargetPair(&dep));
- target.deps().push_back(LabelTargetPair(&dep2));
- target.datadeps().push_back(LabelTargetPair(&datadep));
+ target.public_deps().push_back(LabelTargetPair(&dep));
+ target.public_deps().push_back(LabelTargetPair(&dep2));
+ target.data_deps().push_back(LabelTargetPair(&datadep));
target.SetToolchain(setup.toolchain());
ASSERT_TRUE(target.OnResolved(&err));

Powered by Google App Engine
This is Rietveld 408576698