Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 561243002: ozone: evdev: Move read polling into EventConverterEvdev (Closed)

Created:
6 years, 3 months ago by spang
Modified:
6 years, 3 months ago
Reviewers:
kpschoedel
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Move read polling into EventConverterEvdev All of the subclasses do the same thing for the polling part, so share it. Not all of them use DispatchEventToCallback, so remove that part. NOTRY=true Committed: https://crrev.com/f04d0478359d667814c973ba11d6e8840e00b4be Cr-Commit-Position: refs/heads/master@{#294446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -124 lines) Patch
M ui/events/ozone/evdev/event_converter_evdev.h View 1 chunk +21 lines, -17 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev.cc View 1 chunk +19 lines, -7 lines 0 comments Download
M ui/events/ozone/evdev/key_event_converter_evdev.h View 2 chunks +4 lines, -13 lines 0 comments Download
M ui/events/ozone/evdev/key_event_converter_evdev.cc View 4 chunks +3 lines, -17 lines 0 comments Download
M ui/events/ozone/evdev/key_event_converter_evdev_unittest.cc View 4 chunks +9 lines, -6 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.h View 3 chunks +2 lines, -11 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc View 3 chunks +1 line, -18 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.h View 6 chunks +4 lines, -16 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.cc View 4 chunks +4 lines, -19 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
spang
6 years, 3 months ago (2014-09-11 15:36:48 UTC) #2
kpschoedel
lgtm
6 years, 3 months ago (2014-09-11 16:58:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/561243002/1
6 years, 3 months ago (2014-09-11 19:33:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7d26847854ad8f8814515850d91b51226b8557ba
6 years, 3 months ago (2014-09-11 19:53:17 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 20:02:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f04d0478359d667814c973ba11d6e8840e00b4be
Cr-Commit-Position: refs/heads/master@{#294446}

Powered by Google App Engine
This is Rietveld 408576698