Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 561233004: Make it possible to use mojo_variables.gypi at any depth (Closed)

Created:
6 years, 3 months ago by abarth-chromium
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make it possible to use mojo_variables.gypi at any depth Previously, mojo_variables.gypi hard-coded a DEPTH of 1, which meant that only GYP files that were directly in folders in the root could use it. After this CL, GYP files at any depth of the tree can use it. R=jamesr@chromium.org Committed: https://crrev.com/b568f02e7a37495b6061b35ed8b2ec750a2814e9 Cr-Commit-Position: refs/heads/master@{#294907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M mojo/mojo_variables.gypi View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
abarth-chromium
6 years, 3 months ago (2014-09-15 14:51:11 UTC) #1
jamesr
lgtm, but have your considered using GN for your needs instead?
6 years, 3 months ago (2014-09-15 15:34:47 UTC) #2
abarth-chromium
Yes. Maybe I should switch to gn...
6 years, 3 months ago (2014-09-15 20:13:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/561233004/1
6 years, 3 months ago (2014-09-15 20:24:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2aa52e490fdd307242d2ef8ab13213024dc2ae5d
6 years, 3 months ago (2014-09-15 22:48:50 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 22:50:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b568f02e7a37495b6061b35ed8b2ec750a2814e9
Cr-Commit-Position: refs/heads/master@{#294907}

Powered by Google App Engine
This is Rietveld 408576698