Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: chrome/browser/geolocation/geolocation_infobar_delegate.cc

Issue 56123010: [InfoBar] remove unnecesary checks from some delegates. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/infobars/insecure_content_infobar_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/geolocation/geolocation_infobar_delegate.cc
diff --git a/chrome/browser/geolocation/geolocation_infobar_delegate.cc b/chrome/browser/geolocation/geolocation_infobar_delegate.cc
index fba08a89eafa023f455a41c220ff718af3a046f9..784dc552e20fbe1518ab9b3682e7080d6abf0132 100644
--- a/chrome/browser/geolocation/geolocation_infobar_delegate.cc
+++ b/chrome/browser/geolocation/geolocation_infobar_delegate.cc
@@ -106,11 +106,9 @@ bool GeolocationInfoBarDelegate::Accept() {
void GeolocationInfoBarDelegate::SetPermission(bool update_content_setting,
bool allowed) {
- if (web_contents()) {
- GURL embedder = web_contents()->GetLastCommittedURL().GetOrigin();
- controller_->OnPermissionSet(id_, requesting_frame_, embedder,
- update_content_setting, allowed);
- }
+ controller_->OnPermissionSet(id_, requesting_frame_,
+ web_contents()->GetLastCommittedURL().GetOrigin(),
Peter Kasting 2013/11/05 19:57:52 Nit: All lines of args should begin at the same in
Miguel Garcia 2013/11/06 17:05:58 Done.
+ update_content_setting, allowed);
}
void GeolocationInfoBarDelegate::InfoBarDismissed() {
« no previous file with comments | « no previous file | chrome/browser/infobars/insecure_content_infobar_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698