[InfoBar] remove unnecesary checks from some delegates.

chrome/browser/geolocation/geolocation_infobar_delegate.cc

Index: chrome/browser/geolocation/geolocation_infobar_delegate.cc
diff --git a/chrome/browser/geolocation/geolocation_infobar_delegate.cc b/chrome/browser/geolocation/geolocation_infobar_delegate.cc
index fba08a89eafa023f455a41c220ff718af3a046f9..073a0fff4b02acb2626c4726c73b56fa2e97b134 100644
--- a/chrome/browser/geolocation/geolocation_infobar_delegate.cc
+++ b/chrome/browser/geolocation/geolocation_infobar_delegate.cc
@@ -106,11 +106,8 @@ bool GeolocationInfoBarDelegate::Accept() {
 
 void GeolocationInfoBarDelegate::SetPermission(bool update_content_setting,
                                                bool allowed) {
-  if (web_contents()) {
-    GURL embedder = web_contents()->GetLastCommittedURL().GetOrigin();
-    controller_->OnPermissionSet(id_, requesting_frame_, embedder,
-                                 update_content_setting, allowed);
-  }
+  controller_->OnPermissionSet(id_, requesting_frame_,
+      web_contents()->GetURL(), update_content_setting, allowed);

[Peter Kasting, 2013/11/04 22:14:19]

Nit: All lines of args should begin at the same indent

Does GetURL() do the same thing as GetLastCommittedURL()?  I'd have thought
these would differ when there's a pending navigation.

You also removed the GetOrigin() call, is this already handled by some other
code later in the call chain?

[Michael van Ouwerkerk, 2013/11/05 11:49:06]

Peter is right, these changes are incorrect. Please see
https://chromiumcodereview.appspot.com/23440030/

To summarize:
* This probably reintroduces bug 286667
* GetURL is deprecated

On 2013/11/04 22:14:19, Peter Kasting wrote:

[Miguel Garcia, 2013/11/05 14:17:56]

Thanks for the pointer, I removed the straight git revert and replaced it with
manually removing the if instead.

On 2013/11/05 11:49:06, Michael van Ouwerkerk wrote:

 }
 
 void GeolocationInfoBarDelegate::InfoBarDismissed() {