[InfoBar] remove unnecesary checks from some delegates.

[InfoBar] remove unnecesary checks from some delegates.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233383

[Miguel Garcia, 2013-11-04 18:25:38]

Michael for the geolocation one
Peter for the insecure content one

Context: I had to add the geolocation check for M30 but now that the problem has
been fixed more generally (by fixing the android confirm infobar) this is no
longer needed. While it was a ti and by Peter's recommendation I also removed
the check on the insecure content delegate since it's not needed there either.

[Peter Kasting, 2013-11-04 22:14:19]

https://codereview.chromium.org/56123010/diff/1/chrome/browser/geolocation/ge...
File chrome/browser/geolocation/geolocation_infobar_delegate.cc (right):

https://codereview.chromium.org/56123010/diff/1/chrome/browser/geolocation/ge...
chrome/browser/geolocation/geolocation_infobar_delegate.cc:110:
web_contents()->GetURL(), update_content_setting, allowed);
Nit: All lines of args should begin at the same indent

Does GetURL() do the same thing as GetLastCommittedURL()?  I'd have thought
these would differ when there's a pending navigation.

You also removed the GetOrigin() call, is this already handled by some other
code later in the call chain?

https://codereview.chromium.org/56123010/diff/1/chrome/browser/infobars/insec...
File chrome/browser/infobars/insecure_content_infobar_delegate.cc (right):

https://codereview.chromium.org/56123010/diff/1/chrome/browser/infobars/insec...
chrome/browser/infobars/insecure_content_infobar_delegate.cc:93:
web_contents()->Send(
Nit: The old wrapping (for this whole block) was correct, the new wrapping is
wrong.

[Michael van Ouwerkerk, 2013-11-05 11:49:06]

https://codereview.chromium.org/56123010/diff/1/chrome/browser/geolocation/ge...
File chrome/browser/geolocation/geolocation_infobar_delegate.cc (right):

https://codereview.chromium.org/56123010/diff/1/chrome/browser/geolocation/ge...
chrome/browser/geolocation/geolocation_infobar_delegate.cc:110:
web_contents()->GetURL(), update_content_setting, allowed);
Peter is right, these changes are incorrect. Please see
https://chromiumcodereview.appspot.com/23440030/

To summarize:
* This probably reintroduces bug 286667
* GetURL is deprecated

On 2013/11/04 22:14:19, Peter Kasting wrote:
> Nit: All lines of args should begin at the same indent
> 
> Does GetURL() do the same thing as GetLastCommittedURL()?  I'd have thought
> these would differ when there's a pending navigation.
> 
> You also removed the GetOrigin() call, is this already handled by some other
> code later in the call chain?

[Miguel Garcia, 2013-11-05 14:17:56]

https://codereview.chromium.org/56123010/diff/1/chrome/browser/geolocation/ge...
File chrome/browser/geolocation/geolocation_infobar_delegate.cc (right):

https://codereview.chromium.org/56123010/diff/1/chrome/browser/geolocation/ge...
chrome/browser/geolocation/geolocation_infobar_delegate.cc:110:
web_contents()->GetURL(), update_content_setting, allowed);
Thanks for the pointer, I removed the straight git revert and replaced it with
manually removing the if instead.

On 2013/11/05 11:49:06, Michael van Ouwerkerk wrote:
> Peter is right, these changes are incorrect. Please see
> https://chromiumcodereview.appspot.com/23440030/
> 
> To summarize:
> * This probably reintroduces bug 286667
> * GetURL is deprecated
> 
> On 2013/11/04 22:14:19, Peter Kasting wrote:
> > Nit: All lines of args should begin at the same indent
> > 
> > Does GetURL() do the same thing as GetLastCommittedURL()?  I'd have thought
> > these would differ when there's a pending navigation.
> > 
> > You also removed the GetOrigin() call, is this already handled by some other
> > code later in the call chain?
>

https://codereview.chromium.org/56123010/diff/1/chrome/browser/infobars/insec...
File chrome/browser/infobars/insecure_content_infobar_delegate.cc (right):

https://codereview.chromium.org/56123010/diff/1/chrome/browser/infobars/insec...
chrome/browser/infobars/insecure_content_infobar_delegate.cc:93:
web_contents()->Send(
On 2013/11/04 22:14:19, Peter Kasting wrote:
> Nit: The old wrapping (for this whole block) was correct, the new wrapping is
> wrong.

Done.

[Michael van Ouwerkerk, 2013-11-05 14:22:10]

Thanks! No bug number? Not sure what the style is, but an empty BUG= looks weird
to me.

lgtm

[Peter Kasting, 2013-11-05 19:57:52]

LGTM

"BUG=none" is how I do CLs without an explicit bug.

https://codereview.chromium.org/56123010/diff/130001/chrome/browser/geolocati...
File chrome/browser/geolocation/geolocation_infobar_delegate.cc (right):

https://codereview.chromium.org/56123010/diff/130001/chrome/browser/geolocati...
chrome/browser/geolocation/geolocation_infobar_delegate.cc:110:
web_contents()->GetLastCommittedURL().GetOrigin(),
Nit: All lines of args should begin at the same indentation.

[Miguel Garcia, 2013-11-06 17:05:57]

https://codereview.chromium.org/56123010/diff/130001/chrome/browser/geolocati...
File chrome/browser/geolocation/geolocation_infobar_delegate.cc (right):

https://codereview.chromium.org/56123010/diff/130001/chrome/browser/geolocati...
chrome/browser/geolocation/geolocation_infobar_delegate.cc:110:
web_contents()->GetLastCommittedURL().GetOrigin(),
On 2013/11/05 19:57:52, Peter Kasting wrote:
> Nit: All lines of args should begin at the same indentation.

Done.

[commit-bot: I haz the power, 2013-11-06 17:08:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miguelg@chromium.org/56123010/210001

[commit-bot: I haz the power, 2013-11-06 21:46:13]

Change committed as 233383