chrome/browser/chromeos/input_method/input_method_engine_unittest.cc - Issue 561223002: Updates the histograms for IMF and IMEs according to the new design.

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine_unittest.cc

Issue 561223002: Updates the histograms for IMF and IMEs according to the new design. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed unit_tests. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/input_method/input_method_engine.cc ('K') | « chrome/browser/chromeos/input_method/input_method_engine.cc ('k') | chrome/browser/chromeos/input_method/input_method_manager_impl.h » ('j') | chrome/browser/chromeos/input_method/input_method_manager_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/input_method_engine_unittest.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc b/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc

index 31ce00355a52ac43b6214da39f7c9457ebb2ec44..7e39a3add503d2f07f06ddd566ff22afcd482490 100644

--- a/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc

+++ b/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc

@@ -25,8 +25,7 @@ const char kTestExtensionId2[] = "dmpipdbjkoajgdeppkffbjhngfckdloi";

const char kTestImeComponentId[] = "test_engine_id";

const char* kHistogramNames[] = {

- "InputMethod.Enable.test_engine_id", "InputMethod.Commit.test_engine_id",

- "InputMethod.CommitCharacter.test_engine_id",

+ "InputMethod.CommitLength",

};

scoped_ptr<base::HistogramSamples> GetHistogramSamples(

@@ -280,15 +279,16 @@ TEST_F(InputMethodEngineTest, TestHistograms) {

CreateEngine(true);

FocusIn(ui::TEXT_INPUT_TYPE_TEXT);

engine_->Enable(kTestImeComponentId);

+ std::vector<InputMethodEngineInterface::SegmentInfo> segments;

+ engine_->SetComposition(

+ engine_->GetCotextIdForTesting(), "test", 0, 0, 0, segments, NULL);

std::string error;

- ExpectNewSample("InputMethod.Enable.test_engine_id", 1, 1, 1);

engine_->CommitText(1, "input", &error);

engine_->CommitText(1, "入力", &error);

Seigo Nonaka 2014/09/12 02:15:37 I prefer "\xE5\x85\xA5\xE5\x8A\x9B" with comment l

Shu Chen 2014/09/12 02:57:18 Done.

engine_->CommitText(1, "input入力", &error);

- ExpectNewSample("InputMethod.Commit.test_engine_id", 1, 3, 3);

- ExpectNewSample("InputMethod.CommitCharacter.test_engine_id", 5, 3, 1);

- ExpectNewSample("InputMethod.CommitCharacter.test_engine_id", 2, 3, 1);

- ExpectNewSample("InputMethod.CommitCharacter.test_engine_id", 7, 3, 1);

+ ExpectNewSample("InputMethod.CommitLength", 5, 3, 1);

+ ExpectNewSample("InputMethod.CommitLength", 2, 3, 1);

+ ExpectNewSample("InputMethod.CommitLength", 7, 3, 1);

}

} // namespace input_method