Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1828)

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine.h

Issue 561223002: Updates the histograms for IMF and IMEs according to the new design. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed unit_tests. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_engine.h
diff --git a/chrome/browser/chromeos/input_method/input_method_engine.h b/chrome/browser/chromeos/input_method/input_method_engine.h
index 9aa6364309f92f62e5099533f75059485da596a0..671d09ec8c131378ce34c68180d676330630dfa3 100644
--- a/chrome/browser/chromeos/input_method/input_method_engine.h
+++ b/chrome/browser/chromeos/input_method/input_method_engine.h
@@ -91,9 +91,9 @@ class InputMethodEngine : public InputMethodEngineInterface {
uint32 anchor_pos) OVERRIDE;
virtual void HideInputView() OVERRIDE;
- private:
- void RecordHistogram(const char* name, int count);
+ int GetCotextIdForTesting() { return context_id_; }
+ private:
// Converts MenuItem to InputMethodMenuItem.
void MenuItemToProperty(const MenuItem& item,
ash::ime::InputMethodMenuItem* property);
@@ -140,10 +140,6 @@ class InputMethodEngine : public InputMethodEngineInterface {
// Used with SendKeyEvents and ProcessKeyEvent to check if the key event
// sent to ProcessKeyEvent is sent by SendKeyEvents.
const ui::KeyEvent* sent_key_event_;
-
- // The start & end time of using this input method. This is for UMA.
- base::Time start_time_;
- base::Time end_time_;
};
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698