Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 561203002: Change the way how the saved passwords are cleaned in the password manager python tests. (Closed)

Created:
6 years, 3 months ago by rchtara
Modified:
6 years, 3 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change the way how the saved passwords are cleaned in the password manager python tests. This cl changes the way how the saved passwords are removed. before, they were removed from the the password manager setting page. Now they are cleaned by going to the clean history page, because the tests go already there to clean the cookies. BUG=413237 Committed: https://crrev.com/1894ec5f8e0c1526c575da65840b99ac4ca30f92 Cr-Commit-Position: refs/heads/master@{#294830}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -30 lines) Patch
M components/test/data/password_manager/environment.py View 4 chunks +27 lines, -29 lines 0 comments Download
M components/test/data/password_manager/websitetest.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
rchtara
Hi, Could you please review this cl? Thanks a lot Riadh
6 years, 3 months ago (2014-09-11 13:52:39 UTC) #2
vabr (Chromium)
LGTM, Thanks!
6 years, 3 months ago (2014-09-15 14:59:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/561203002/1
6 years, 3 months ago (2014-09-15 15:00:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2a4f6adf658eafbcae5fcdac285179888a857ef1
6 years, 3 months ago (2014-09-15 15:59:12 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1894ec5f8e0c1526c575da65840b99ac4ca30f92 Cr-Commit-Position: refs/heads/master@{#294830}
6 years, 3 months ago (2014-09-15 16:07:54 UTC) #7
chromium-reviews
6 years, 3 months ago (2014-09-15 16:14:14 UTC) #8
Thanks a lot for the review
Riadh

On Mon, Sep 15, 2014 at 5:59 PM, <commit-bot@chromium.org> wrote:

> Committed patchset #1 (id:1) as 2a4f6adf658eafbcae5fcdac285179888a857ef1
>
> https://codereview.chromium.org/561203002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698