Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 561193004: gn: fix last_commit_position.py and yasm_assemble.gni (Closed)

Created:
6 years, 3 months ago by piman
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gn: fix last_commit_position.py and yasm_assemble.gni 1- use the correct directory for git commands 2- yasm needs . in the include search path, otherwise I get: FAILED: python ../../../third_party/yasm/run_yasm.py ./yasm -DPIC -felf64 -m amd64 -I../../.. -Igen -DARCH_X86_64 -w -P ../../../third_party/ffmpeg/chromium/config/Chromium/linux/x64/config.asm -I../../../third_party/ffmpeg/chromium/config/Chromium/linux/x64 -I../../../third_party/ffmpeg/libavcodec/x86 -I../../../third_party/ffmpeg/libavutil/x86 -I../../../third_party/ffmpeg -DPIC -o obj/third_party/ffmpeg/vp8dsp.o ../../../third_party/ffmpeg/libavcodec/x86/vp8dsp.asm yasm: FATAL: unable to open include file `../../../third_party/ffmpeg/chromium/config/Chromium/linux/x64/config.asm' BUG=None Committed: https://crrev.com/1c5731d3c4397e3ad41ae3c47089896d057a59c2 Cr-Commit-Position: refs/heads/master@{#294679}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/yasm/yasm_assemble.gni View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/last_commit_position.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
piman
Not sure why other people don't run into the yasm issue. I think it's because ...
6 years, 3 months ago (2014-09-12 04:14:52 UTC) #2
brettw
LGTM
6 years, 3 months ago (2014-09-12 21:25:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/561193004/1
6 years, 3 months ago (2014-09-12 21:38:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 10fb747ffdb0672663a94cccaa7a4fa5c5055132
6 years, 3 months ago (2014-09-12 22:17:10 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 22:20:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c5731d3c4397e3ad41ae3c47089896d057a59c2
Cr-Commit-Position: refs/heads/master@{#294679}

Powered by Google App Engine
This is Rietveld 408576698