Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 561193003: New Test for 'vertical-align has no effect on a flex item' (Closed)

Created:
6 years, 3 months ago by Sunil Ratnu
Modified:
6 years, 2 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

New Test for 'vertical-align has no effect on a flex item' The spec says that 'vertical-align' has no effect on a flex item. Currently there are no tests for specifically checking this, so added a new test case for verifying the same. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183308

Patch Set 1 #

Patch Set 2 : Removed float: + Added background colors #

Patch Set 3 : Minor correction: s/grid/flexbox #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -8 lines) Patch
A + LayoutTests/css3/flexbox/vertical-align-do-not-effect-flex-items.html View 1 2 2 chunks +9 lines, -8 lines 0 comments Download
A LayoutTests/css3/flexbox/vertical-align-do-not-effect-flex-items-expected.html View 1 2 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Sunil Ratnu
While writing a test case for 'vertical-align' for grid: https://codereview.chromium.org/543493004/ , saw that we do ...
6 years, 3 months ago (2014-09-11 12:59:27 UTC) #2
Sunil Ratnu
Gentle ping. Please have a look? Thanks!
6 years, 3 months ago (2014-09-18 03:02:07 UTC) #3
Sunil Ratnu
On 2014/09/18 03:02:07, Sunil Ratnu wrote: > Gentle ping. Please have a look? Thanks! Gentle ...
6 years, 3 months ago (2014-09-23 19:51:00 UTC) #4
cbiesinger
lgtm
6 years, 2 months ago (2014-10-06 22:43:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/561193003/20001
6 years, 2 months ago (2014-10-07 03:03:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/561193003/40001
6 years, 2 months ago (2014-10-07 05:03:15 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 06:32:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 183308

Powered by Google App Engine
This is Rietveld 408576698