Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 561173006: Fix some android gn configuration (Closed)

Created:
6 years, 3 months ago by cjhopman
Modified:
6 years, 3 months ago
Reviewers:
jamesr, brettw, eseidel
CC:
blink-reviews, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix some android gn configuration Fix file missing due to sources_assignment_filter. Fix some use_openmax config (Depends on http://crrev.com/568363002). BUG=359249 TBR=eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182119

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M Source/config.gni View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/web/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
cjhopman
brettw: * eseidel: *
6 years, 3 months ago (2014-09-15 00:27:31 UTC) #2
jamesr
lgtm (although the patch description doesn't cover all the changes)
6 years, 3 months ago (2014-09-15 00:36:29 UTC) #4
jamesr
Oh wait it does, I just didn't read it all.
6 years, 3 months ago (2014-09-15 00:36:40 UTC) #5
cjhopman
eseidel to TBR (for the trivial change to Source/config.gni)
6 years, 3 months ago (2014-09-16 19:17:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/561173006/1
6 years, 3 months ago (2014-09-16 19:19:15 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/19583)
6 years, 3 months ago (2014-09-16 19:25:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/561173006/1
6 years, 3 months ago (2014-09-16 22:20:29 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 23:11:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182119

Powered by Google App Engine
This is Rietveld 408576698