Mixed Content: Migrate ResourceFetcher to the static mixed content checker.

Mixed Content: Migrate ResourceFetcher to the static mixed content checker.

This patch begins using the static version of the mixed content checker
which was introduced in https://codereview.chromium.org/537983002/. It
also takes the opportunity to rework the error message to use the new
type information we've now passed into the checker.

This patch only touches the ResourceFetcher usage; future patches will
clean up the other points in the code where we grab a MixedContentChecker
from the loader, and eventually remove the object creation entirely.
This will make the site isolation folks happy.

BUG=411184
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181817

[Mike West, 2014-09-11 08:49:28]

Patchset #1 (id:1) has been deleted

[Mike West, 2014-09-11 08:54:06]

+nasko@: FYI. Remember how I said we could get rid of the MixedContentChecker on
FrameLoader? :)

[Mike West, 2014-09-11 09:09:02]

mkwst@chromium.org changed reviewers:
+ jochen@chromium.org, philipj@opera.com, sigbjornf@opera.com

[Mike West, 2014-09-11 09:09:03]

Would one of you fine folks mind taking a look at this patch?

(I'm running low on reviewers in my time zone...)

[sof, 2014-09-11 09:34:43]

https://codereview.chromium.org/561153002/diff/40001/Source/core/fetch/Resour...
File Source/core/fetch/ResourceFetcher.cpp (left):

https://codereview.chromium.org/561153002/diff/40001/Source/core/fetch/Resour...
Source/core/fetch/ResourceFetcher.cpp:629: // If we're loading the main resource
of a subframe, ensure that we treat the resource as active
Do you need to adjust this comment to fit what's now done just below?

[Mike West, 2014-09-11 09:49:36]

https://codereview.chromium.org/561153002/diff/40001/Source/core/fetch/Resour...
File Source/core/fetch/ResourceFetcher.cpp (left):

https://codereview.chromium.org/561153002/diff/40001/Source/core/fetch/Resour...
Source/core/fetch/ResourceFetcher.cpp:629: // If we're loading the main resource
of a subframe, ensure that we treat the resource as active
On 2014/09/11 09:34:42, sof wrote:
> Do you need to adjust this comment to fit what's now done just below?

I do need to drop that bit of the comment. Thanks for pointing it out.

[Mike West, 2014-09-11 11:34:02]

Fixed the comment and a failing test. Mind taking another look?

[sof, 2014-09-11 11:35:27]

On 2014/09/11 09:49:36, Mike West wrote:
>
https://codereview.chromium.org/561153002/diff/40001/Source/core/fetch/Resour...
> File Source/core/fetch/ResourceFetcher.cpp (left):
> 
>
https://codereview.chromium.org/561153002/diff/40001/Source/core/fetch/Resour...
> Source/core/fetch/ResourceFetcher.cpp:629: // If we're loading the main
resource
> of a subframe, ensure that we treat the resource as active
> On 2014/09/11 09:34:42, sof wrote:
> > Do you need to adjust this comment to fit what's now done just below?
> 
> I do need to drop that bit of the comment. Thanks for pointing it out.

alright, lgtm.

[Mike West, 2014-09-11 11:40:00]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2014-09-11 11:40:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/561153002/60001

[commit-bot: I haz the power, 2014-09-11 13:07:12]

Committed patchset #3 (id:60001) as 181817