Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 561133005: Change the order of arguments of the (One|Two)ByteSeqStringSetChar intrinsic. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 3344 matching lines...) Expand 10 before | Expand all | Expand 10 after
3355 3355
3356 3356
3357 void FullCodeGenerator::EmitOneByteSeqStringSetChar(CallRuntime* expr) { 3357 void FullCodeGenerator::EmitOneByteSeqStringSetChar(CallRuntime* expr) {
3358 ZoneList<Expression*>* args = expr->arguments(); 3358 ZoneList<Expression*>* args = expr->arguments();
3359 DCHECK_EQ(3, args->length()); 3359 DCHECK_EQ(3, args->length());
3360 3360
3361 Register string = eax; 3361 Register string = eax;
3362 Register index = ebx; 3362 Register index = ebx;
3363 Register value = ecx; 3363 Register value = ecx;
3364 3364
3365 VisitForStackValue(args->at(1)); // index 3365 VisitForStackValue(args->at(0)); // index
3366 VisitForStackValue(args->at(2)); // value 3366 VisitForStackValue(args->at(1)); // value
3367 VisitForAccumulatorValue(args->at(0)); // string 3367 VisitForAccumulatorValue(args->at(2)); // string
3368 3368
3369 __ pop(value); 3369 __ pop(value);
3370 __ pop(index); 3370 __ pop(index);
3371 3371
3372 if (FLAG_debug_code) { 3372 if (FLAG_debug_code) {
3373 __ test(value, Immediate(kSmiTagMask)); 3373 __ test(value, Immediate(kSmiTagMask));
3374 __ Check(zero, kNonSmiValue); 3374 __ Check(zero, kNonSmiValue);
3375 __ test(index, Immediate(kSmiTagMask)); 3375 __ test(index, Immediate(kSmiTagMask));
3376 __ Check(zero, kNonSmiValue); 3376 __ Check(zero, kNonSmiValue);
3377 } 3377 }
(...skipping 13 matching lines...) Expand all
3391 3391
3392 3392
3393 void FullCodeGenerator::EmitTwoByteSeqStringSetChar(CallRuntime* expr) { 3393 void FullCodeGenerator::EmitTwoByteSeqStringSetChar(CallRuntime* expr) {
3394 ZoneList<Expression*>* args = expr->arguments(); 3394 ZoneList<Expression*>* args = expr->arguments();
3395 DCHECK_EQ(3, args->length()); 3395 DCHECK_EQ(3, args->length());
3396 3396
3397 Register string = eax; 3397 Register string = eax;
3398 Register index = ebx; 3398 Register index = ebx;
3399 Register value = ecx; 3399 Register value = ecx;
3400 3400
3401 VisitForStackValue(args->at(1)); // index 3401 VisitForStackValue(args->at(0)); // index
3402 VisitForStackValue(args->at(2)); // value 3402 VisitForStackValue(args->at(1)); // value
3403 VisitForAccumulatorValue(args->at(0)); // string 3403 VisitForAccumulatorValue(args->at(2)); // string
3404 __ pop(value); 3404 __ pop(value);
3405 __ pop(index); 3405 __ pop(index);
3406 3406
3407 if (FLAG_debug_code) { 3407 if (FLAG_debug_code) {
3408 __ test(value, Immediate(kSmiTagMask)); 3408 __ test(value, Immediate(kSmiTagMask));
3409 __ Check(zero, kNonSmiValue); 3409 __ Check(zero, kNonSmiValue);
3410 __ test(index, Immediate(kSmiTagMask)); 3410 __ test(index, Immediate(kSmiTagMask));
3411 __ Check(zero, kNonSmiValue); 3411 __ Check(zero, kNonSmiValue);
3412 __ SmiUntag(index); 3412 __ SmiUntag(index);
3413 static const uint32_t two_byte_seq_type = kSeqStringTag | kTwoByteStringTag; 3413 static const uint32_t two_byte_seq_type = kSeqStringTag | kTwoByteStringTag;
(...skipping 1409 matching lines...) Expand 10 before | Expand all | Expand 10 after
4823 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 4823 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
4824 Assembler::target_address_at(call_target_address, 4824 Assembler::target_address_at(call_target_address,
4825 unoptimized_code)); 4825 unoptimized_code));
4826 return OSR_AFTER_STACK_CHECK; 4826 return OSR_AFTER_STACK_CHECK;
4827 } 4827 }
4828 4828
4829 4829
4830 } } // namespace v8::internal 4830 } } // namespace v8::internal
4831 4831
4832 #endif // V8_TARGET_ARCH_IA32 4832 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698