Issue 561133005: Change the order of arguments of the (One|Two)ByteSeqStringSetChar intrinsic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 561133005: Change the order of arguments of the (One|Two)ByteSeqStringSetChar intrinsic. (Closed)

Created:
6 years, 3 months ago by Jarin

Modified:
6 years, 3 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Change the order of arguments of the (One|Two)ByteSeqStringSetChar intrinsic. This makes the syntactic order consistent with the evaluation order. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23899

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+87 lines, -89 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/arm64/full-codegen-arm64.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/hydrogen.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/mips64/full-codegen-mips64.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/runtime.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/string.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/uri.js	View	4 chunks	+14 lines, -14 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/x87/full-codegen-x87.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	test/mjsunit/lithium/SeqStringSetChar.js	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	test/mjsunit/regress/regress-crbug-320922.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/mjsunit/regress/regress-seqstrsetchar-ex1.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/regress/regress-seqstrsetchar-ex3.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/mjsunit/regress/string-set-char-deopt.js	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	test/mjsunit/string-natives.js	View	1 chunk	+7 lines, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

Jarin

6 years, 3 months ago (2014-09-12 08:18:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 23899 (presubmit successful).