Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: chrome/browser/chromeos/file_manager/open_util.cc

Issue 561133004: Update the error message in the Files app via Downloads panel. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/file_manager/open_util.cc
diff --git a/chrome/browser/chromeos/file_manager/open_util.cc b/chrome/browser/chromeos/file_manager/open_util.cc
index dbe75ccf4fd98645c7197c5b0ab98428807413b8..11be4178b6f587dcf31b9d3070946bffc1f74019 100644
--- a/chrome/browser/chromeos/file_manager/open_util.cc
+++ b/chrome/browser/chromeos/file_manager/open_util.cc
@@ -142,8 +142,14 @@ void OnContinueOpenItemCompleted(Profile* profile,
const base::FilePath& file_path,
bool result) {
if (!result) {
- ShowWarningMessageBox(
- profile, file_path, IDS_FILE_BROWSER_ERROR_VIEWING_FILE);
+ int message;
+ if (file_path.Extension() == ".dmg")
kinaba 2014/09/11 08:50:41 FILE_PATH_LITERAL(".dmg") base::FilePath holds UT
iseki 2014/09/11 09:18:58 Done.
+ message = IDS_FILE_BROWSER_ERROR_VIEWING_FILE_FOR_DMG;
+ else if (file_path.Extension() == ".exe")
kinaba 2014/09/11 08:50:41 Would you mind checking ".msi" and returning the s
iseki 2014/09/11 09:18:58 Done.
+ message = IDS_FILE_BROWSER_ERROR_VIEWING_FILE_FOR_EXECUTABLE;
+ else
+ message = IDS_FILE_BROWSER_ERROR_VIEWING_FILE;
+ ShowWarningMessageBox(profile, file_path, message);
}
}
« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698