Update the error message in the Files app via Downloads panel.

Update the error message in the Files app via Downloads panel.

BUG=399333
TEST=manually
1. Download .exe file.
2. Click the item in Downloads panel.

Committed: https://crrev.com/a02d54cf9835a4dc96a3c1b9a869e384a25b3246
Cr-Commit-Position: refs/heads/master@{#294369}

[iseki, 2014-09-11 08:43:29]

iseki@chromium.org changed reviewers:
+ kinaba@chromium.org

[iseki, 2014-09-11 08:43:29]

Please take a look.

[kinaba, 2014-09-11 08:50:41]

Thanks for taking this!

https://codereview.chromium.org/561133004/diff/1/chrome/browser/chromeos/file...
File chrome/browser/chromeos/file_manager/open_util.cc (right):

https://codereview.chromium.org/561133004/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_manager/open_util.cc:146: if (file_path.Extension()
== ".dmg")
FILE_PATH_LITERAL(".dmg")

base::FilePath holds UTF-16 chars on Windows and UTF-8 on others.
FILE_PATH_LITERAL is a macro for absorbing the type difference.

Although the current code runs only on Chrome OS, we still want
to keep the code as portable as possible.

Same applies for ".exe" below.

https://codereview.chromium.org/561133004/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_manager/open_util.cc:148: else if
(file_path.Extension() == ".exe")
Would you mind checking ".msi" and returning the same message as ".exe"?
Actually I've silently tweaked it a bit for JS code last week. :)
https://codereview.chromium.org/541593003/

[iseki, 2014-09-11 09:18:58]

Thank you for your review :)

https://codereview.chromium.org/561133004/diff/1/chrome/browser/chromeos/file...
File chrome/browser/chromeos/file_manager/open_util.cc (right):

https://codereview.chromium.org/561133004/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_manager/open_util.cc:146: if (file_path.Extension()
== ".dmg")
On 2014/09/11 08:50:41, kinaba wrote:
> FILE_PATH_LITERAL(".dmg")
> 
> base::FilePath holds UTF-16 chars on Windows and UTF-8 on others.
> FILE_PATH_LITERAL is a macro for absorbing the type difference.
> 
> Although the current code runs only on Chrome OS, we still want
> to keep the code as portable as possible.
> 
> Same applies for ".exe" below.

Done.

https://codereview.chromium.org/561133004/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_manager/open_util.cc:148: else if
(file_path.Extension() == ".exe")
On 2014/09/11 08:50:41, kinaba wrote:
> Would you mind checking ".msi" and returning the same message as ".exe"?
> Actually I've silently tweaked it a bit for JS code last week. :)
> https://codereview.chromium.org/541593003/

Done.

[kinaba, 2014-09-11 09:24:21]

lgtm

[iseki, 2014-09-11 09:26:54]

The CQ bit was checked by iseki@chromium.org

[commit-bot: I haz the power, 2014-09-11 09:27:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/561133004/20001

[commit-bot: I haz the power, 2014-09-11 10:51:04]

Committed patchset #2 (id:20001) as 7ab34e4a36c0e00dcee7810883450211e7442fe8

[commit-bot: I haz the power, 2014-09-11 10:54:47]

Patchset 2 (id:??) landed as
https://crrev.com/a02d54cf9835a4dc96a3c1b9a869e384a25b3246
Cr-Commit-Position: refs/heads/master@{#294369}