Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1308)

Unified Diff: sync/notifier/invalidation_notifier.cc

Issue 56113003: Implement new invalidations ack tracking system (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Modify drive TODO comment + rebase Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/notifier/invalidation_notifier.h ('k') | sync/notifier/invalidation_notifier_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/notifier/invalidation_notifier.cc
diff --git a/sync/notifier/invalidation_notifier.cc b/sync/notifier/invalidation_notifier.cc
index e3c79a44117d97e21edf6fc99aae614cb007c1d9..a509409c76d00c8b912d1333c668a7773599341e 100644
--- a/sync/notifier/invalidation_notifier.cc
+++ b/sync/notifier/invalidation_notifier.cc
@@ -20,17 +20,17 @@ namespace syncer {
InvalidationNotifier::InvalidationNotifier(
scoped_ptr<notifier::PushClient> push_client,
const std::string& invalidator_client_id,
- const InvalidationStateMap& initial_invalidation_state_map,
+ const UnackedInvalidationsMap& saved_invalidations,
const std::string& invalidation_bootstrap_data,
const WeakHandle<InvalidationStateTracker>& invalidation_state_tracker,
const std::string& client_info)
: state_(STOPPED),
- initial_invalidation_state_map_(initial_invalidation_state_map),
+ saved_invalidations_(saved_invalidations),
invalidation_state_tracker_(invalidation_state_tracker),
client_info_(client_info),
invalidator_client_id_(invalidator_client_id),
invalidation_bootstrap_data_(invalidation_bootstrap_data),
- invalidation_listener_(&tick_clock_, push_client.Pass()) {
+ invalidation_listener_(push_client.Pass()) {
}
InvalidationNotifier::~InvalidationNotifier() {
@@ -54,12 +54,6 @@ void InvalidationNotifier::UnregisterHandler(InvalidationHandler* handler) {
registrar_.UnregisterHandler(handler);
}
-void InvalidationNotifier::Acknowledge(const invalidation::ObjectId& id,
- const AckHandle& ack_handle) {
- DCHECK(CalledOnValidThread());
- invalidation_listener_.Acknowledge(id, ack_handle);
-}
-
InvalidatorState InvalidationNotifier::GetInvalidatorState() const {
DCHECK(CalledOnValidThread());
return registrar_.GetInvalidatorState();
@@ -71,7 +65,7 @@ void InvalidationNotifier::UpdateCredentials(
invalidation_listener_.Start(
base::Bind(&invalidation::CreateInvalidationClient),
invalidator_client_id_, client_info_, invalidation_bootstrap_data_,
- initial_invalidation_state_map_,
+ saved_invalidations_,
invalidation_state_tracker_,
this);
state_ = STARTED;
« no previous file with comments | « sync/notifier/invalidation_notifier.h ('k') | sync/notifier/invalidation_notifier_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698