Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: sync/internal_api/public/base/invalidation.cc

Issue 56113003: Implement new invalidations ack tracking system (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Modify drive TODO comment + rebase Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/internal_api/public/base/invalidation.h ('k') | sync/internal_api/public/base/model_type_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/public/base/invalidation.cc
diff --git a/sync/internal_api/public/base/invalidation.cc b/sync/internal_api/public/base/invalidation.cc
index 1292a51bbe670198f22c896ad653bd760e19e1f8..ff7a5a78fd4dc542856a768b08565552e1823150 100644
--- a/sync/internal_api/public/base/invalidation.cc
+++ b/sync/internal_api/public/base/invalidation.cc
@@ -111,10 +111,6 @@ const AckHandle& Invalidation::ack_handle() const {
return ack_handle_;
}
-void Invalidation::set_ack_handle(const AckHandle& ack_handle) {
- ack_handle_ = ack_handle;
-}
-
void Invalidation::set_ack_handler(syncer::WeakHandle<AckHandler> handler) {
ack_handler_ = handler;
}
@@ -135,10 +131,12 @@ void Invalidation::Acknowledge() const {
void Invalidation::Drop(DroppedInvalidationTracker* tracker) const {
DCHECK(tracker->object_id() == object_id());
tracker->RecordDropEvent(ack_handler_, ack_handle_);
- ack_handler_.Call(FROM_HERE,
- &AckHandler::Drop,
- id_,
- ack_handle_);
+ if (SupportsAcknowledgement()) {
+ ack_handler_.Call(FROM_HERE,
+ &AckHandler::Drop,
+ id_,
+ ack_handle_);
+ }
}
bool Invalidation::Equals(const Invalidation& other) const {
« no previous file with comments | « sync/internal_api/public/base/invalidation.h ('k') | sync/internal_api/public/base/model_type_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698