chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h - Issue 56113003: Implement new invalidations ack tracking system

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h

Issue 56113003: Implement new invalidations ack tracking system (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Modify drive TODO comment + rebase Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/push_messaging/push_messaging_apitest.cc ('k') | chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h

diff --git a/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h b/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h

index 4f7d9e3975f91f6403d20028c5237e84ce2c40d0..dfb89e67e2a832d9182ee2b506375ac78b97ff64 100644

--- a/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h

+++ b/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h

@@ -5,6 +5,7 @@

#ifndef CHROME_BROWSER_EXTENSIONS_API_PUSH_MESSAGING_PUSH_MESSAGING_INVALIDATION_HANDLER_H_

#define CHROME_BROWSER_EXTENSIONS_API_PUSH_MESSAGING_PUSH_MESSAGING_INVALIDATION_HANDLER_H_

+#include <map>

#include <set>

#include <string>

@@ -13,6 +14,7 @@

#include "base/threading/thread_checker.h"

#include "chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_mapper.h"

#include "sync/notifier/invalidation_handler.h"

+#include "sync/notifier/invalidation_util.h"

namespace invalidation {

class InvalidationService;

@@ -60,6 +62,9 @@ class PushMessagingInvalidationHandler : public PushMessagingInvalidationMapper,

std::set<std::string> registered_extensions_;

syncer::ObjectIdSet suppressed_ids_;

PushMessagingInvalidationHandlerDelegate* const delegate_;

+ std::map<invalidation::ObjectId,

+ int64,

+ syncer::ObjectIdLessThan> max_object_version_map_;

DISALLOW_COPY_AND_ASSIGN(PushMessagingInvalidationHandler);

};