Chromium Code Reviews| Index: chrome/browser/drive/drive_notification_manager.cc |
| diff --git a/chrome/browser/drive/drive_notification_manager.cc b/chrome/browser/drive/drive_notification_manager.cc |
| index d4141b0a83ea552701c9e38ce864509662481564..9d1788250a495645d125f9d4b1aa2acc66018190 100644 |
| --- a/chrome/browser/drive/drive_notification_manager.cc |
| +++ b/chrome/browser/drive/drive_notification_manager.cc |
| @@ -9,6 +9,7 @@ |
| #include "chrome/browser/invalidation/invalidation_service.h" |
| #include "chrome/browser/invalidation/invalidation_service_factory.h" |
| #include "google/cacheinvalidation/types.pb.h" |
| +#include "sync/notifier/object_id_invalidation_map.h" |
| namespace drive { |
| @@ -75,12 +76,8 @@ void DriveNotificationManager::OnIncomingInvalidation( |
| kDriveInvalidationObjectId); |
| DCHECK_EQ(1U, ids.count(object_id)); |
| - // TODO(dcheng): Only acknowledge the invalidation once the fetch has |
| - // completed. http://crbug.com/156843 |
| - DCHECK(invalidation_service_); |
| - syncer::Invalidation inv = invalidation_map.ForObject(object_id).back(); |
| - invalidation_service_->AcknowledgeInvalidation(object_id, inv.ack_handle()); |
| - |
| + // TODO: Acknowledge only after fetch completes. |
|
tim (not reviewing)
2013/11/18 21:59:05
File a new bug for this since (old bug is closed).
rlarocque
2013/11/19 00:35:49
Done.
|
| + invalidation_map.AcknowledgeAll(); |
| NotifyObserversToUpdate(NOTIFICATION_XMPP); |
| } |