Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: chrome/browser/invalidation/invalidator_storage.h

Issue 56113003: Implement new invalidations ack tracking system (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Modify drive TODO comment + rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Wraps PrefService in an InvalidationStateTracker to allow SyncNotifiers 5 // Wraps PrefService in an InvalidationStateTracker to allow SyncNotifiers
6 // to use PrefService as persistence for invalidation state. It is not thread 6 // to use PrefService as persistence for invalidation state. It is not thread
7 // safe, and lives on the UI thread. 7 // safe, and lives on the UI thread.
8 8
9 #ifndef CHROME_BROWSER_INVALIDATION_INVALIDATOR_STORAGE_H_ 9 #ifndef CHROME_BROWSER_INVALIDATION_INVALIDATOR_STORAGE_H_
10 #define CHROME_BROWSER_INVALIDATION_INVALIDATOR_STORAGE_H_ 10 #define CHROME_BROWSER_INVALIDATION_INVALIDATOR_STORAGE_H_
11 11
12 #include "base/basictypes.h" 12 #include "base/basictypes.h"
13 #include "base/gtest_prod_util.h" 13 #include "base/gtest_prod_util.h"
14 #include "base/memory/weak_ptr.h" 14 #include "base/memory/weak_ptr.h"
15 #include "base/threading/thread_checker.h" 15 #include "base/threading/thread_checker.h"
16 #include "sync/notifier/invalidation_state_tracker.h" 16 #include "sync/notifier/invalidation_state_tracker.h"
17 #include "sync/notifier/unacked_invalidation_set.h"
17 18
18 class PrefService; 19 class PrefService;
19 20
20 namespace base { 21 namespace base {
21 class DictionaryValue; 22 class DictionaryValue;
22 class ListValue; 23 class ListValue;
23 } 24 }
24 25
25 namespace user_prefs { 26 namespace user_prefs {
26 class PrefRegistrySyncable; 27 class PrefRegistrySyncable;
27 } 28 }
28 29
29 namespace invalidation { 30 namespace invalidation {
30 31
31 class InvalidatorStorage : public base::SupportsWeakPtr<InvalidatorStorage>, 32 class InvalidatorStorage : public base::SupportsWeakPtr<InvalidatorStorage>,
32 public syncer::InvalidationStateTracker { 33 public syncer::InvalidationStateTracker {
33 public: 34 public:
34 static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry); 35 static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
35 36
36 // |pref_service| may not be NULL. Does not own |pref_service|. 37 // |pref_service| may not be NULL. Does not own |pref_service|.
37 explicit InvalidatorStorage(PrefService* pref_service); 38 explicit InvalidatorStorage(PrefService* pref_service);
38 virtual ~InvalidatorStorage(); 39 virtual ~InvalidatorStorage();
39 40
40 // InvalidationStateTracker implementation. 41 // InvalidationStateTracker implementation.
41 virtual syncer::InvalidationStateMap GetAllInvalidationStates() const
42 OVERRIDE;
43 virtual void SetMaxVersionAndPayload(const invalidation::ObjectId& id,
44 int64 max_version,
45 const std::string& payload) OVERRIDE;
46 virtual void Forget(const syncer::ObjectIdSet& ids) OVERRIDE;
47 virtual void SetInvalidatorClientId(const std::string& client_id) OVERRIDE; 42 virtual void SetInvalidatorClientId(const std::string& client_id) OVERRIDE;
48 virtual std::string GetInvalidatorClientId() const OVERRIDE; 43 virtual std::string GetInvalidatorClientId() const OVERRIDE;
49 virtual void SetBootstrapData(const std::string& data) OVERRIDE; 44 virtual void SetBootstrapData(const std::string& data) OVERRIDE;
50 virtual std::string GetBootstrapData() const OVERRIDE; 45 virtual std::string GetBootstrapData() const OVERRIDE;
46 virtual void SetSavedInvalidations(
47 const syncer::UnackedInvalidationsMap& map) OVERRIDE;
48 virtual syncer::UnackedInvalidationsMap GetSavedInvalidations()
49 const OVERRIDE;
51 virtual void Clear() OVERRIDE; 50 virtual void Clear() OVERRIDE;
52 virtual void GenerateAckHandles(
53 const syncer::ObjectIdSet& ids,
54 const scoped_refptr<base::TaskRunner>& task_runner,
55 base::Callback<void(const syncer::AckHandleMap&)> callback) OVERRIDE;
56 virtual void Acknowledge(const invalidation::ObjectId& id,
57 const syncer::AckHandle& ack_handle) OVERRIDE;
58 51
59 private: 52 private:
60 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, SerializeEmptyMap); 53 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, SerializeEmptyMap);
61 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, 54 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest,
62 DeserializeFromListOutOfRange); 55 DeserializeFromListOutOfRange);
63 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, 56 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest,
64 DeserializeFromListInvalidFormat); 57 DeserializeFromListInvalidFormat);
65 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, 58 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest,
66 DeserializeFromListWithDuplicates); 59 DeserializeFromListWithDuplicates);
67 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, 60 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest,
68 DeserializeFromEmptyList); 61 DeserializeFromEmptyList);
69 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, DeserializeFromListBasic); 62 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, DeserializeFromListBasic);
70 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, 63 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest,
71 DeserializeFromListMissingOptionalValues); 64 DeserializeFromListMissingOptionalValues);
72 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, DeserializeMapOutOfRange); 65 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, DeserializeMapOutOfRange);
73 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, DeserializeMapInvalidFormat); 66 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, DeserializeMapInvalidFormat);
74 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, 67 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest,
75 DeserializeMapEmptyDictionary); 68 DeserializeMapEmptyDictionary);
76 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, DeserializeMapBasic); 69 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, DeserializeMapBasic);
77 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, MigrateLegacyPreferences); 70 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, MigrateLegacyPreferences);
78 71
79 base::ThreadChecker thread_checker_; 72 base::ThreadChecker thread_checker_;
80 73
81 // Helpers to convert between InvalidationStateMap <--> ListValue.
82 static void DeserializeFromList(
83 const base::ListValue& state_map_list,
84 syncer::InvalidationStateMap* state_map);
85 static void SerializeToList(
86 const syncer::InvalidationStateMap& state_map,
87 base::ListValue* state_map_list);
88
89 // Code for migrating from old MaxInvalidationVersions pref, which was a map
90 // from sync types to max invalidation versions.
91 void MigrateMaxInvalidationVersionsPref();
92 static void DeserializeMap(const base::DictionaryValue* max_versions_dict,
93 syncer::InvalidationStateMap* map);
94
95 PrefService* const pref_service_; 74 PrefService* const pref_service_;
96 75
97 DISALLOW_COPY_AND_ASSIGN(InvalidatorStorage); 76 DISALLOW_COPY_AND_ASSIGN(InvalidatorStorage);
98 }; 77 };
99 78
100 } // namespace invalidation 79 } // namespace invalidation
101 80
102 #endif // CHROME_BROWSER_INVALIDATION_INVALIDATOR_STORAGE_H_ 81 #endif // CHROME_BROWSER_INVALIDATION_INVALIDATOR_STORAGE_H_
OLDNEW
« no previous file with comments | « chrome/browser/invalidation/invalidation_service_android.cc ('k') | chrome/browser/invalidation/invalidator_storage.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698