Implement new invalidations ack tracking system

sync/notifier/invalidation_util.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Various utilities for dealing with invalidation data types.
 
 #ifndef SYNC_NOTIFIER_INVALIDATION_UTIL_H_
 #define SYNC_NOTIFIER_INVALIDATION_UTIL_H_
 
 #include <iosfwd>
 #include <set>
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
+#include "google/cacheinvalidation/include/types.h"

[akalin, 2013/11/21 04:31:36]

is this necessary? don't we want to keep the invalidation protobuf headers from
being pulled in by clients?

[rlarocque, 2013/11/21 20:09:27]

This one can be removed.  It's fixed in the latest upload.

There are other places where it must be included, though.  Most often it's
included so we can get the definition of invalidation::ObjectId.

Maybe some day we can land a change to the upstream cacheinvalidation code that
pulls that definition into a separate header file.  That would let us eliminate
most of these includes.

 #include "sync/base/sync_export.h"
 #include "sync/internal_api/public/base/model_type.h"
 
 namespace base {
 class DictionaryValue;
 }  // namespace
 
 namespace invalidation {
 
 class Invalidation;
@@ skipping 39 matching lines @@
 
 SYNC_EXPORT_PRIVATE ObjectIdSet ModelTypeSetToObjectIdSet(ModelTypeSet models);
 ModelTypeSet ObjectIdSetToModelTypeSet(const ObjectIdSet& ids);
 
 std::string InvalidationToString(
     const invalidation::Invalidation& invalidation);
 
 }  // namespace syncer
 
 #endif  // SYNC_NOTIFIER_INVALIDATION_UTIL_H_