Implement new invalidations ack tracking system

chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/strings/string_number_conversions.h"
@@ skipping 107 matching lines @@
 
 void PushMessagingInvalidationHandler::OnInvalidatorStateChange(
     syncer::InvalidatorState state) {
   DCHECK(thread_checker_.CalledOnValidThread());
   // Nothing to do.
 }
 
 void PushMessagingInvalidationHandler::OnIncomingInvalidation(
     const syncer::ObjectIdInvalidationMap& invalidation_map) {
   DCHECK(thread_checker_.CalledOnValidThread());
+  invalidation_map.AcknowledgeAll();
+
   syncer::ObjectIdSet ids = invalidation_map.GetObjectIds();
   for (syncer::ObjectIdSet::const_iterator it = ids.begin();
        it != ids.end(); ++it) {
     const syncer::SingleObjectInvalidationSet& list =
         invalidation_map.ForObject(*it);
     const syncer::Invalidation& invalidation = list.back();
-    service_->AcknowledgeInvalidation(*it, invalidation.ack_handle());
 
     std::string payload;
     if (invalidation.is_unknown_version()) {
       payload = std::string();
     } else {
       payload = list.back().payload();
     }
 
-    syncer::ObjectIdSet::iterator suppressed_id =
-        suppressed_ids_.find(*it);
+    syncer::ObjectIdSet::iterator suppressed_id = suppressed_ids_.find(*it);
     if (suppressed_id != suppressed_ids_.end()) {
       suppressed_ids_.erase(suppressed_id);
       continue;
     }
     DVLOG(2) << "Incoming push message, id is: "
              << syncer::ObjectIdToString(*it)
              << " and payload is:" << payload;
 
     std::string extension_id;
     int subchannel;
     if (ObjectIdToExtensionAndSubchannel(*it, &extension_id, &subchannel)) {
-      DVLOG(2) << "Sending push message to reciever, extension is "
-               << extension_id << ", subchannel is " << subchannel
-               << ", and payload is " << payload;
-      delegate_->OnMessage(extension_id, subchannel, payload);
+      const syncer::SingleObjectInvalidationSet& invalidation_list =
+          invalidation_map.ForObject(*it);
+
+      // We always forward unknown version invalidation when we receive one.
+      if (invalidation_list.StartsWithUnknownVersion()) {
+        DVLOG(2) << "Sending push message to reciever, extension is "
+            << extension_id << ", subchannel is " << subchannel
+            << "and payload was lost";
+        delegate_->OnMessage(extension_id, subchannel, std::string());
+      }
+
+      // If we receive a new max version for this object, forward its payload.
+      const syncer::Invalidation& max_invalidation = invalidation_list.back();
+      if (!max_invalidation.is_unknown_version() &&
+          max_invalidation.version() > max_object_version_map_[*it]) {
+        max_object_version_map_[*it] = max_invalidation.version();
+        DVLOG(2) << "Sending push message to reciever, extension is "
+            << extension_id << ", subchannel is " << subchannel
+            << ", and payload is " << max_invalidation.payload();
+        delegate_->OnMessage(extension_id,
+                             subchannel,
+                             max_invalidation.payload());
+      }
     }
   }
 }
 
 void PushMessagingInvalidationHandler::UpdateRegistrations() {
   syncer::ObjectIdSet ids;
   for (std::set<std::string>::const_iterator it =
        registered_extensions_.begin(); it != registered_extensions_.end();
        ++it) {
     const syncer::ObjectIdSet& object_ids = ExtensionIdToObjectIds(*it);
     ids.insert(object_ids.begin(), object_ids.end());
   }
   service_->UpdateRegisteredInvalidationIds(this, ids);
 }
 
 }  // namespace extensions