Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Side by Side Diff: chrome/browser/invalidation/invalidator_storage.h

Issue 56113003: Implement new invalidations ack tracking system (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Wraps PrefService in an InvalidationStateTracker to allow SyncNotifiers 5 // Wraps PrefService in an InvalidationStateTracker to allow SyncNotifiers
6 // to use PrefService as persistence for invalidation state. It is not thread 6 // to use PrefService as persistence for invalidation state. It is not thread
7 // safe, and lives on the UI thread. 7 // safe, and lives on the UI thread.
8 8
9 #ifndef CHROME_BROWSER_INVALIDATION_INVALIDATOR_STORAGE_H_ 9 #ifndef CHROME_BROWSER_INVALIDATION_INVALIDATOR_STORAGE_H_
10 #define CHROME_BROWSER_INVALIDATION_INVALIDATOR_STORAGE_H_ 10 #define CHROME_BROWSER_INVALIDATION_INVALIDATOR_STORAGE_H_
11 11
12 #include "base/basictypes.h" 12 #include "base/basictypes.h"
13 #include "base/gtest_prod_util.h" 13 #include "base/gtest_prod_util.h"
14 #include "base/memory/weak_ptr.h" 14 #include "base/memory/weak_ptr.h"
15 #include "base/threading/thread_checker.h" 15 #include "base/threading/thread_checker.h"
16 #include "sync/notifier/invalidation_state_tracker.h" 16 #include "sync/notifier/invalidation_state_tracker.h"
17 #include "sync/notifier/unacked_invalidation_set.h"
17 18
18 class PrefService; 19 class PrefService;
19 20
20 namespace base { 21 namespace base {
21 class DictionaryValue; 22 class DictionaryValue;
22 class ListValue; 23 class ListValue;
23 } 24 }
24 25
25 namespace user_prefs { 26 namespace user_prefs {
26 class PrefRegistrySyncable; 27 class PrefRegistrySyncable;
27 } 28 }
28 29
29 namespace invalidation { 30 namespace invalidation {
30 31
31 class InvalidatorStorage : public base::SupportsWeakPtr<InvalidatorStorage>, 32 class InvalidatorStorage : public base::SupportsWeakPtr<InvalidatorStorage>,
32 public syncer::InvalidationStateTracker { 33 public syncer::InvalidationStateTracker {
33 public: 34 public:
34 static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry); 35 static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
35 36
36 // |pref_service| may be NULL (for unit tests), but in that case no setter 37 // |pref_service| may be NULL (for unit tests), but in that case no setter
37 // methods should be called. Does not own |pref_service|. 38 // methods should be called. Does not own |pref_service|.
38 explicit InvalidatorStorage(PrefService* pref_service); 39 explicit InvalidatorStorage(PrefService* pref_service);
39 virtual ~InvalidatorStorage(); 40 virtual ~InvalidatorStorage();
40 41
41 // InvalidationStateTracker implementation. 42 // InvalidationStateTracker implementation.
42 virtual syncer::InvalidationStateMap GetAllInvalidationStates() const
43 OVERRIDE;
44 virtual void SetMaxVersionAndPayload(const invalidation::ObjectId& id,
45 int64 max_version,
46 const std::string& payload) OVERRIDE;
47 virtual void Forget(const syncer::ObjectIdSet& ids) OVERRIDE;
48 virtual void SetInvalidatorClientId(const std::string& client_id) OVERRIDE; 43 virtual void SetInvalidatorClientId(const std::string& client_id) OVERRIDE;
49 virtual std::string GetInvalidatorClientId() const OVERRIDE; 44 virtual std::string GetInvalidatorClientId() const OVERRIDE;
50 virtual void SetBootstrapData(const std::string& data) OVERRIDE; 45 virtual void SetBootstrapData(const std::string& data) OVERRIDE;
51 virtual std::string GetBootstrapData() const OVERRIDE; 46 virtual std::string GetBootstrapData() const OVERRIDE;
47 virtual void SetSavedInvalidations(
48 const syncer::UnackedInvalidationsMap& map) OVERRIDE;
49 virtual syncer::UnackedInvalidationsMap GetSavedInvalidations()
50 const OVERRIDE;
52 virtual void Clear() OVERRIDE; 51 virtual void Clear() OVERRIDE;
53 virtual void GenerateAckHandles(
54 const syncer::ObjectIdSet& ids,
55 const scoped_refptr<base::TaskRunner>& task_runner,
56 base::Callback<void(const syncer::AckHandleMap&)> callback) OVERRIDE;
57 virtual void Acknowledge(const invalidation::ObjectId& id,
58 const syncer::AckHandle& ack_handle) OVERRIDE;
59 52
60 private: 53 private:
61 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, SerializeEmptyMap); 54 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, SerializeEmptyMap);
62 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, 55 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest,
63 DeserializeFromListOutOfRange); 56 DeserializeFromListOutOfRange);
64 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, 57 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest,
65 DeserializeFromListInvalidFormat); 58 DeserializeFromListInvalidFormat);
66 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, 59 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest,
67 DeserializeFromListWithDuplicates); 60 DeserializeFromListWithDuplicates);
68 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, 61 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest,
69 DeserializeFromEmptyList); 62 DeserializeFromEmptyList);
70 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, DeserializeFromListBasic); 63 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, DeserializeFromListBasic);
71 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, 64 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest,
72 DeserializeFromListMissingOptionalValues); 65 DeserializeFromListMissingOptionalValues);
73 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, DeserializeMapOutOfRange); 66 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, DeserializeMapOutOfRange);
74 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, DeserializeMapInvalidFormat); 67 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, DeserializeMapInvalidFormat);
75 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, 68 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest,
76 DeserializeMapEmptyDictionary); 69 DeserializeMapEmptyDictionary);
77 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, DeserializeMapBasic); 70 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, DeserializeMapBasic);
78 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, MigrateLegacyPreferences); 71 FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, MigrateLegacyPreferences);
79 72
80 base::ThreadChecker thread_checker_; 73 base::ThreadChecker thread_checker_;
81 74
82 // Helpers to convert between InvalidationStateMap <--> ListValue.
83 static void DeserializeFromList(
84 const base::ListValue& state_map_list,
85 syncer::InvalidationStateMap* state_map);
86 static void SerializeToList(
87 const syncer::InvalidationStateMap& state_map,
88 base::ListValue* state_map_list);
89
90 // Code for migrating from old MaxInvalidationVersions pref, which was a map
91 // from sync types to max invalidation versions.
92 void MigrateMaxInvalidationVersionsPref();
93 static void DeserializeMap(const base::DictionaryValue* max_versions_dict,
94 syncer::InvalidationStateMap* map);
95
96 // May be NULL. 75 // May be NULL.
97 PrefService* const pref_service_; 76 PrefService* const pref_service_;
98 77
99 DISALLOW_COPY_AND_ASSIGN(InvalidatorStorage); 78 DISALLOW_COPY_AND_ASSIGN(InvalidatorStorage);
100 }; 79 };
101 80
102 } // namespace invalidation 81 } // namespace invalidation
103 82
104 #endif // CHROME_BROWSER_INVALIDATION_INVALIDATOR_STORAGE_H_ 83 #endif // CHROME_BROWSER_INVALIDATION_INVALIDATOR_STORAGE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698