Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 561093003: Remove worker support of Web SQL Database. (Closed)

Created:
6 years, 3 months ago by tkent
Modified:
6 years, 3 months ago
CC:
abarth-chromium, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, dglazkov+blink, falken, horo+watch_chromium.org, jamesr, kinuko+worker_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove worker support of Web SQL Database. Intent to remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/SYlD0YVUnQk Remove all *Sync interfaces and implementations, and WorkerGlobalScope:: openDatabase. CLs to simplify code follow. BUG=397429, 323858, 310866, 357427 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181790

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -3890 lines) Patch
M LayoutTests/FlakyTests View 2 chunks +0 lines, -16 lines 0 comments Download
M LayoutTests/SlowTests View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/TestExpectations View 3 chunks +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/workers/storage/change-version-handle-reuse-sync.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/workers/storage/change-version-handle-reuse-sync-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/fast/workers/storage/change-version-handle-reuse-worker.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/workers/storage/change-version-handle-reuse-worker-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/fast/workers/storage/change-version-sync.html View 1 chunk +0 lines, -49 lines 0 comments Download
D LayoutTests/fast/workers/storage/change-version-sync-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/workers/storage/empty-statement-sync.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/workers/storage/empty-statement-sync-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/workers/storage/execute-sql-args-sync.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/workers/storage/execute-sql-args-sync-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/fast/workers/storage/execute-sql-args-worker.html View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/workers/storage/execute-sql-args-worker-expected.txt View 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/fast/workers/storage/executesql-accepts-only-one-statement-sync.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/workers/storage/executesql-accepts-only-one-statement-sync-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/workers/storage/interrupt-database.html View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/fast/workers/storage/interrupt-database-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/workers/storage/interrupt-database-sync.html-disabled View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/fast/workers/storage/interrupt-database-sync-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/workers/storage/multiple-databases-garbage-collection.html View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/workers/storage/multiple-databases-garbage-collection-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/workers/storage/multiple-transactions.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/workers/storage/multiple-transactions-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/fast/workers/storage/multiple-transactions-on-different-handles.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/workers/storage/multiple-transactions-on-different-handles-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/workers/storage/multiple-transactions-on-different-handles-sync.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/workers/storage/multiple-transactions-on-different-handles-sync-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/workers/storage/open-database-creation-callback-sync.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/workers/storage/open-database-creation-callback-sync-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/fast/workers/storage/open-database-empty-version-sync.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/workers/storage/open-database-empty-version-sync-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/workers/storage/open-database-inputs-sync.html View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/workers/storage/open-database-inputs-sync-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/workers/storage/open-database-set-empty-version-sync.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/workers/storage/open-database-set-empty-version-sync-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/workers/storage/open-database-while-transaction-in-progress.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/workers/storage/open-database-while-transaction-in-progress-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/workers/storage/open-database-while-transaction-in-progress-sync.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/workers/storage/open-database-while-transaction-in-progress-sync-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/workers/storage/read-and-write-transactions-dont-run-together.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/workers/storage/read-and-write-transactions-dont-run-together-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/change-version-handle-reuse-sync.js View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/change-version-sync-1.js View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/change-version-sync-2.js View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/database-worker.js View 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/database-worker-controller.js View 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/empty-statement-sync.js View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/execute-sql-args-sync.js View 1 chunk +0 lines, -70 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/executesql-accepts-only-one-statement-sync.js View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/interrupt-database.js View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/interrupt-database-sync.js View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/multiple-transactions-on-different-handles-sync.js View 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/multiple-transactions-sync.js View 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/open-database-creation-callback-sync.js View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/open-database-empty-version-sync.js View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/open-database-inputs-sync.js View 1 chunk +0 lines, -74 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/open-database-set-empty-version-sync.js View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/open-database-while-transaction-in-progress-sync.js View 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/sql-data-types-sync.js View 1 chunk +0 lines, -36 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/sql-exception-codes-sync.js View 1 chunk +0 lines, -88 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/test-authorizer-sync.js View 1 chunk +0 lines, -126 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/test-inputs-common.js View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/transaction-in-transaction-sync.js View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/workers/storage/resources/use-same-database-in-page-and-workers.js View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/fast/workers/storage/sql-data-types-sync.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/workers/storage/sql-data-types-sync-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/fast/workers/storage/sql-exception-codes-sync.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/workers/storage/sql-exception-codes-sync-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/workers/storage/test-authorizer.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/workers/storage/test-authorizer-expected.txt View 1 chunk +0 lines, -69 lines 0 comments Download
D LayoutTests/fast/workers/storage/test-authorizer-sync.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/workers/storage/transaction-in-transaction-sync.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/workers/storage/transaction-in-transaction-sync-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/workers/storage/use-same-database-in-page-and-workers.html View 1 chunk +0 lines, -88 lines 0 comments Download
D LayoutTests/fast/workers/storage/use-same-database-in-page-and-workers-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-worker-websql-allowed.html View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-worker-websql-allowed-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/http/tests/security/resources/cross-origin-iframe-for-worker-websql.html View 1 chunk +0 lines, -21 lines 0 comments Download
M LayoutTests/http/tests/workers/resources/sync-operations.js View 1 chunk +1 line, -3 lines 0 comments Download
D LayoutTests/http/tests/workers/terminate-during-sync-operation-websql.html View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/http/tests/workers/terminate-during-sync-operation-websql-expected.txt View 1 chunk +0 lines, -69 lines 0 comments Download
D LayoutTests/platform/linux/fast/workers/storage/test-authorizer-expected.txt View 1 chunk +0 lines, -70 lines 0 comments Download
D LayoutTests/platform/linux/fast/workers/storage/test-authorizer-sync-expected.txt View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/platform/mac/fast/workers/storage/test-authorizer-expected.txt View 1 chunk +0 lines, -70 lines 0 comments Download
D LayoutTests/platform/mac/fast/workers/storage/test-authorizer-sync-expected.txt View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/platform/win/fast/workers/storage/test-authorizer-sync-expected.txt View 1 chunk +0 lines, -72 lines 0 comments Download
D Source/bindings/modules/v8/custom/V8SQLTransactionSyncCustom.cpp View 1 chunk +0 lines, -101 lines 0 comments Download
M Source/bindings/modules/v8/custom/custom.gni View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/modules/v8/custom/custom.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 2 chunks +0 lines, -11 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 2 chunks +0 lines, -14 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/modules.gypi View 7 chunks +0 lines, -17 lines 0 comments Download
M Source/modules/webdatabase/AbstractDatabaseServer.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/modules/webdatabase/AbstractSQLStatement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webdatabase/AbstractSQLTransaction.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/webdatabase/AbstractSQLTransactionBackend.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/webdatabase/DatabaseBackend.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseBackendBase.h View 5 chunks +3 lines, -7 lines 0 comments Download
M Source/modules/webdatabase/DatabaseBackendBase.cpp View 11 chunks +7 lines, -21 lines 0 comments Download
D Source/modules/webdatabase/DatabaseBackendSync.h View 1 chunk +0 lines, -57 lines 0 comments Download
D Source/modules/webdatabase/DatabaseBackendSync.cpp View 1 chunk +0 lines, -67 lines 0 comments Download
M Source/modules/webdatabase/DatabaseBase.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webdatabase/DatabaseBasicTypes.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/modules/webdatabase/DatabaseCallback.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DatabaseCallback.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseContext.h View 3 chunks +1 line, -22 lines 0 comments Download
M Source/modules/webdatabase/DatabaseContext.cpp View 4 chunks +0 lines, -61 lines 0 comments Download
M Source/modules/webdatabase/DatabaseManager.h View 3 chunks +3 lines, -5 lines 0 comments Download
M Source/modules/webdatabase/DatabaseManager.cpp View 5 chunks +3 lines, -35 lines 0 comments Download
M Source/modules/webdatabase/DatabaseServer.h View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/modules/webdatabase/DatabaseServer.cpp View 2 chunks +4 lines, -19 lines 0 comments Download
D Source/modules/webdatabase/DatabaseSync.h View 1 chunk +0 lines, -104 lines 0 comments Download
D Source/modules/webdatabase/DatabaseSync.cpp View 1 chunk +0 lines, -212 lines 0 comments Download
D Source/modules/webdatabase/DatabaseSync.idl View 1 chunk +0 lines, -41 lines 0 comments Download
M Source/modules/webdatabase/DatabaseTracker.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseTracker.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
M Source/modules/webdatabase/SQLStatementBackend.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/modules/webdatabase/SQLStatementSync.h View 1 chunk +0 lines, -61 lines 0 comments Download
D Source/modules/webdatabase/SQLStatementSync.cpp View 1 chunk +0 lines, -140 lines 0 comments Download
M Source/modules/webdatabase/SQLTransaction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLTransactionBackend.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/modules/webdatabase/SQLTransactionBackendSync.h View 1 chunk +0 lines, -85 lines 0 comments Download
D Source/modules/webdatabase/SQLTransactionBackendSync.cpp View 1 chunk +0 lines, -261 lines 0 comments Download
D Source/modules/webdatabase/SQLTransactionSync.h View 1 chunk +0 lines, -54 lines 0 comments Download
D Source/modules/webdatabase/SQLTransactionSync.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
D Source/modules/webdatabase/SQLTransactionSync.idl View 1 chunk +0 lines, -36 lines 0 comments Download
D Source/modules/webdatabase/SQLTransactionSyncCallback.h View 1 chunk +0 lines, -50 lines 0 comments Download
D Source/modules/webdatabase/SQLTransactionSyncCallback.idl View 1 chunk +0 lines, -33 lines 0 comments Download
D Source/modules/webdatabase/WorkerGlobalScopeWebDatabase.h View 1 chunk +0 lines, -53 lines 0 comments Download
D Source/modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp View 1 chunk +0 lines, -81 lines 0 comments Download
D Source/modules/webdatabase/WorkerGlobalScopeWebDatabase.idl View 1 chunk +0 lines, -33 lines 0 comments Download
M Source/web/WebDatabase.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M public/platform/WebDatabaseObserver.h View 1 chunk +2 lines, -0 lines 0 comments Download
M public/web/WebDatabase.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
Please review this.
6 years, 3 months ago (2014-09-11 02:25:29 UTC) #3
esprehn
lgtm
6 years, 3 months ago (2014-09-11 02:45:17 UTC) #4
haraken
LGTM!
6 years, 3 months ago (2014-09-11 02:55:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/561093003/20001
6 years, 3 months ago (2014-09-11 04:32:36 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 04:38:01 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as 181790

Powered by Google App Engine
This is Rietveld 408576698