Use ONC carrier info in JS

Use ONC carrier info in JS

Also, cleanup internet_options_handler.cc 'showViewAccountButton' code.

BUG=279351
Committed: https://crrev.com/fbe23b5a93835d5a98cf06cf00aebcd6faf6746a
Cr-Commit-Position: refs/heads/master@{#294951}

[stevenjb, 2014-09-11 00:55:28]

stevenjb@chromium.org changed reviewers:
+ armansito@chromium.org

[stevenjb, 2014-09-11 00:55:29]

Arman, I have no idea how to test this, can you either provide instructions or
test the patch? Thanks!

[armansito, 2014-09-11 17:22:25]

On 2014/09/11 00:55:29, stevenjb wrote:
> Arman, I have no idea how to test this, can you either provide instructions or
> test the patch? Thanks!

You should be able test this using pseudomodem. Giving the command line tool the
"--activated=false" flag should make the network show up as not-activated, which
should allow you to test the view account button code.

Other than that the "--family" option allows you to specify CDMA vs 3GPP which
should be enough to test the various carrier values in internet_detail.

[stevenjb, 2014-09-11 17:34:32]

On 2014/09/11 17:22:25, armansito wrote:
> On 2014/09/11 00:55:29, stevenjb wrote:
> > Arman, I have no idea how to test this, can you either provide instructions
or
> > test the patch? Thanks!
> 
> You should be able test this using pseudomodem. Giving the command line tool
the
> "--activated=false" flag should make the network show up as not-activated,
which
> should allow you to test the view account button code.
> 
> Other than that the "--family" option allows you to specify CDMA vs 3GPP which
> should be enough to test the various carrier values in internet_detail.

It is the carrier select code that I am unsure how to test.

[stevenjb, 2014-09-11 17:55:59]

stevenjb@chromium.org changed reviewers:
+ tbarzic@chromium.org

[stevenjb, 2014-09-11 17:55:59]

+tbarzic@ - Toni, do you know any way to test the carrier UI?

[Ben Chan, 2014-09-11 18:12:35]

On 2014/09/11 17:55:59, stevenjb wrote:
> +tbarzic@ - Toni, do you know any way to test the carrier UI?

We can test it on our cellular DUT with a gobi3k modem.

[stevenjb, 2014-09-11 18:43:47]

Patchset #2 (id:20001) has been deleted

[stevenjb, 2014-09-11 18:44:54]

Apologies, the previous patch didn't actually compile and had a couple of JS
errors.

I added a list of supported carriers in the fake/stub implementation and was
able to test the UI, but it would be great to test on an actual device also.

[stevenjb, 2014-09-12 17:05:09]

Fake impl + test data added, ptal.

[armansito, 2014-09-12 17:05:49]

lgtm

[stevenjb, 2014-09-15 22:47:31]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-09-15 22:56:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/561073002/120001

[commit-bot: I haz the power, 2014-09-16 00:55:27]

Committed patchset #6 (id:120001) as 961cf4a050f995042b62f3039de5b2310102aeac

[commit-bot: I haz the power, 2014-09-16 00:59:39]

Patchset 6 (id:??) landed as
https://crrev.com/fbe23b5a93835d5a98cf06cf00aebcd6faf6746a
Cr-Commit-Position: refs/heads/master@{#294951}