Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 561063002: Reland of -fno-exceptions only on .cc files https://codereview.chromium.org/560873003/ with fix for… (Closed)

Created:
6 years, 3 months ago by scottmg
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland of -fno-exceptions only on .cc files https://codereview.chromium.org/560873003/ with fix for ASAN LSAN libc++ build removed from cflags, so wasn't removed. I don't see any other instances of doing this in https://code.google.com/p/chromium/codesearch#search/&q=fno-exceptions&sq=package:chromium&type=cs R=earthdok@chromium.org, thakis@chromium.org BUG=335824 Committed: https://chromium.googlesource.com/chromium/src/+/9ebc1b919dcb529f7d4182ac6f2334b89366f142

Patch Set 1 #

Patch Set 2 : sort #

Patch Set 3 : and another #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/common.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/libc++/libc++.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/libc++abi/libc++abi.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (5 generated)
scottmg
6 years, 3 months ago (2014-09-11 00:37:25 UTC) #2
Nico
Behold my codesearch skills: https://code.google.com/p/chromium/codesearch#search/&q=fno-exceptions%20file:gyp&sq=package:chromium&type=cs => https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libc%2B%2Babi/libc%2B%2Babi.gyp&ct=rc&cd=9&q=fno-exceptions%20file:gyp&sq=package:chromium&l=43&dr=C needs this too I think.
6 years, 3 months ago (2014-09-11 00:39:45 UTC) #3
scottmg
Thank you! On 2014/09/11 00:39:45, Nico (hiding) wrote: > Behold my codesearch skills: > https://code.google.com/p/chromium/codesearch#search/&q=fno-exceptions%20file:gyp&sq=package:chromium&type=cs ...
6 years, 3 months ago (2014-09-11 00:42:21 UTC) #4
Nico
lgtm (My query included file:gyp, so it was on the first page. I know I ...
6 years, 3 months ago (2014-09-11 00:44:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/561063002/60001
6 years, 3 months ago (2014-09-11 00:55:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/10173)
6 years, 3 months ago (2014-09-11 01:20:59 UTC) #9
scottmg
+earthdok or +glider for third_party/libc++*/OWNERS
6 years, 3 months ago (2014-09-11 02:24:49 UTC) #11
earthdok
lgtm
6 years, 3 months ago (2014-09-11 12:56:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/561063002/60001
6 years, 3 months ago (2014-09-11 16:49:35 UTC) #14
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/9ebc1b919dcb529f7d4182ac6f2334b89366f142 Cr-Commit-Position: refs/heads/master@{#294408}
6 years, 3 months ago (2014-09-11 17:15:10 UTC) #15
scottmg
6 years, 3 months ago (2014-09-11 17:29:39 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as 9ebc1b9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698