runtime/bin/vmservice/observatory/test/mirror_references_test.dart - Issue 561053003: Give fields a model class in the service library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/observatory/test/mirror_references_test.dart

Issue 561053003: Give fields a model class in the service library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: build Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/vmservice/observatory/test/mirror_references_test.dart

diff --git a/runtime/bin/vmservice/observatory/test/mirror_references_test.dart b/runtime/bin/vmservice/observatory/test/mirror_references_test.dart

index 651803a54c0239af585adb17abcaef545f5a3196..b3c782cbf1316397742e24d0324bb12daaed029a 100644

--- a/runtime/bin/vmservice/observatory/test/mirror_references_test.dart

+++ b/runtime/bin/vmservice/observatory/test/mirror_references_test.dart

@@ -27,10 +27,10 @@ var tests = [

(Isolate isolate) =>

isolate.rootLib.load().then((Library lib) {

- ServiceMap fooField = lib.variables.singleWhere((v) => v.name == 'foo');

- Instance foo = fooField['value'];

- ServiceMap refField = lib.variables.singleWhere((v) => v.name == 'ref');

- Instance ref = refField['value'];

+ Field fooField = lib.variables.singleWhere((v) => v.name == 'foo');

+ Instance foo = fooField.value;

+ Field refField = lib.variables.singleWhere((v) => v.name == 'ref');

+ Instance ref = refField.value;

expect(foo.isMirrorReference, isFalse);

expect(ref.isMirrorReference, isTrue);