Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 561043002: cc: Add trace events to track main thread latency mode (Closed)

Created:
6 years, 3 months ago by brianderson
Modified:
6 years, 2 months ago
Reviewers:
jdduke (slow), Sami
CC:
chromium-reviews, cc-bugs_chromium.org, yufeng
Base URL:
https://chromium.googlesource.com/chromium/src.git@snclogging
Project:
chromium
Visibility:
Public.

Description

cc: Add trace events to track main thread latency mode This will make easy to tell when the main thread is in a high latency mode without having to infer based on the surrounding context. BUG=none Committed: https://crrev.com/bca35e1882f448b92b0d79e2ce786629db96adec Cr-Commit-Position: refs/heads/master@{#297110}

Patch Set 1 #

Patch Set 2 : add disabled by default counter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M cc/scheduler/scheduler.cc View 1 2 chunks +12 lines, -2 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brianderson
ptal. Jared was asking for something like this earlier.
6 years, 3 months ago (2014-09-10 22:54:52 UTC) #2
Sami
lgtm, looks useful! Just an idea, but another option would be to add a trace ...
6 years, 3 months ago (2014-09-11 11:36:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/561043002/20001
6 years, 2 months ago (2014-09-27 05:37:17 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 2b3a54932d4d5c0a0bc67ab357b833d28f1e92f7
6 years, 2 months ago (2014-09-27 08:00:17 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-27 08:00:49 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bca35e1882f448b92b0d79e2ce786629db96adec
Cr-Commit-Position: refs/heads/master@{#297110}

Powered by Google App Engine
This is Rietveld 408576698