Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2836)

Unified Diff: chrome/browser/ui/views/toolbar/browser_actions_container.cc

Issue 561023002: Use the wrench menu as a reference view for overflowed extension actions' popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master for CQ Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/toolbar/browser_actions_container.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/toolbar/browser_actions_container.cc
diff --git a/chrome/browser/ui/views/toolbar/browser_actions_container.cc b/chrome/browser/ui/views/toolbar/browser_actions_container.cc
index 5ed94f3e2f00e37eb91ffd966dbf4b2c33d79a12..457fbdbbd37285e423c2f8d4da33e0178df0559c 100644
--- a/chrome/browser/ui/views/toolbar/browser_actions_container.cc
+++ b/chrome/browser/ui/views/toolbar/browser_actions_container.cc
@@ -18,6 +18,7 @@
#include "chrome/browser/ui/views/extensions/browser_action_drag_data.h"
#include "chrome/browser/ui/views/extensions/extension_keybinding_registry_views.h"
#include "chrome/browser/ui/views/extensions/extension_popup.h"
+#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/toolbar/browser_actions_container_observer.h"
#include "chrome/browser/ui/views/toolbar/toolbar_view.h"
#include "chrome/common/extensions/command.h"
@@ -283,10 +284,11 @@ void BrowserActionsContainer::OnBrowserActionViewDragDone() {
}
views::View* BrowserActionsContainer::GetOverflowReferenceView() {
- // We should only need an overflow reference when using the traditional
- // chevron overflow.
- DCHECK(chevron_);
- return chevron_;
+ // With traditional overflow, the reference is the chevron. With the
+ // redesign, we use the wrench menu instead.
+ return chevron_ ?
+ chevron_ :
+ BrowserView::GetBrowserViewForBrowser(browser_)->toolbar()->app_menu();
}
void BrowserActionsContainer::SetPopupOwner(BrowserActionView* popup_owner) {
@@ -300,6 +302,13 @@ void BrowserActionsContainer::HideActivePopup() {
popup_owner_->view_controller()->HidePopup();
}
+BrowserActionView* BrowserActionsContainer::GetMainViewForExtension(
+ const Extension* extension) {
+ return in_overflow_mode() ?
+ main_container_->GetViewForExtension(extension) :
+ GetViewForExtension(extension);
+}
+
void BrowserActionsContainer::AddObserver(
BrowserActionsContainerObserver* observer) {
observers_.AddObserver(observer);
« no previous file with comments | « chrome/browser/ui/views/toolbar/browser_actions_container.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698