Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: chrome/browser/ui/views/location_bar/page_action_image_view.h

Issue 561023002: Use the wrench menu as a reference view for overflowed extension actions' popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master for CQ Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_PAGE_ACTION_IMAGE_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_PAGE_ACTION_IMAGE_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_PAGE_ACTION_IMAGE_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_PAGE_ACTION_IMAGE_VIEW_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 // Overridden from View. 58 // Overridden from View.
59 virtual void PaintChildren(gfx::Canvas* canvas, 59 virtual void PaintChildren(gfx::Canvas* canvas,
60 const views::CullSet& cull_set) OVERRIDE; 60 const views::CullSet& cull_set) OVERRIDE;
61 61
62 // Overridden from ExtensionActionViewDelegate: 62 // Overridden from ExtensionActionViewDelegate:
63 virtual void OnIconUpdated() OVERRIDE; 63 virtual void OnIconUpdated() OVERRIDE;
64 virtual views::View* GetAsView() OVERRIDE; 64 virtual views::View* GetAsView() OVERRIDE;
65 virtual bool IsShownInMenu() OVERRIDE; 65 virtual bool IsShownInMenu() OVERRIDE;
66 virtual views::FocusManager* GetFocusManagerForAccelerator() OVERRIDE; 66 virtual views::FocusManager* GetFocusManagerForAccelerator() OVERRIDE;
67 virtual views::Widget* GetParentForContextMenu() OVERRIDE; 67 virtual views::Widget* GetParentForContextMenu() OVERRIDE;
68 virtual ExtensionActionViewController* GetPreferredPopupViewController()
69 OVERRIDE;
68 virtual views::View* GetReferenceViewForPopup() OVERRIDE; 70 virtual views::View* GetReferenceViewForPopup() OVERRIDE;
69 virtual content::WebContents* GetCurrentWebContents() OVERRIDE; 71 virtual content::WebContents* GetCurrentWebContents() OVERRIDE;
70 virtual void HideActivePopup() OVERRIDE; 72 virtual void HideActivePopup() OVERRIDE;
71 73
72 // The controller for this ExtensionAction view. 74 // The controller for this ExtensionAction view.
73 scoped_ptr<ExtensionActionViewController> view_controller_; 75 scoped_ptr<ExtensionActionViewController> view_controller_;
74 76
75 // The location bar view that owns us. 77 // The location bar view that owns us.
76 LocationBarView* owner_; 78 LocationBarView* owner_;
77 79
78 // The string to show for a tooltip; 80 // The string to show for a tooltip;
79 std::string tooltip_; 81 std::string tooltip_;
80 82
81 // This is used for post-install visual feedback. The page_action icon is 83 // This is used for post-install visual feedback. The page_action icon is
82 // briefly shown even if it hasn't been enabled by its extension. 84 // briefly shown even if it hasn't been enabled by its extension.
83 bool preview_enabled_; 85 bool preview_enabled_;
84 86
85 DISALLOW_IMPLICIT_CONSTRUCTORS(PageActionImageView); 87 DISALLOW_IMPLICIT_CONSTRUCTORS(PageActionImageView);
86 }; 88 };
87 89
88 #endif // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_PAGE_ACTION_IMAGE_VIEW_H_ 90 #endif // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_PAGE_ACTION_IMAGE_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698