DescriptionRevert of Simplify test locales in ui_unittests Framework (patchset #1 id:1 of https://codereview.chromium.org/552963002/)
Reason for revert:
Bizarrely, this is causing valgrind on Snow Leopard to pick up a
bunch of leaks from allocations within system libraries.
Reverting while I figure out how best to fix that.
BUG=413034
Original issue's description:
> Simplify test locales in Mac's ui_unittests Framework
>
> Mac creates a mini-framework in `ui_unittests Framework` so that ui
> tests can get a resource bundle without depending on the Chrome
> framework.
>
> The way it generated locale information was causing build flakes since
> two instances of repack_locales.py could be writing to
> out/../gen/repack. Tests always use en-US, so instead just do what iOS
> does and copy ui_test.pak to en.lproj/locale.pak and roll it into the
> mini-framework bundle.
>
> BUG=410468
>
> Committed: https://crrev.com/bac8fafd3d056f1277c2fdf44d2a66ca19252e54
> Cr-Commit-Position: refs/heads/master@{#294052}
TBR=avi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=410468
Committed: https://crrev.com/adfa5731821d44c3e6e1704e156e61cff089b58f
Cr-Commit-Position: refs/heads/master@{#294321}
Patch Set 1 #
Created: 6 years, 3 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|