Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 560993004: Revert of Simplify test locales in ui_unittests Framework (Closed)

Created:
6 years, 3 months ago by tapted
Modified:
6 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, oshima+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Simplify test locales in ui_unittests Framework (patchset #1 id:1 of https://codereview.chromium.org/552963002/) Reason for revert: Bizarrely, this is causing valgrind on Snow Leopard to pick up a bunch of leaks from allocations within system libraries. Reverting while I figure out how best to fix that. BUG=413034 Original issue's description: > Simplify test locales in Mac's ui_unittests Framework > > Mac creates a mini-framework in `ui_unittests Framework` so that ui > tests can get a resource bundle without depending on the Chrome > framework. > > The way it generated locale information was causing build flakes since > two instances of repack_locales.py could be writing to > out/../gen/repack. Tests always use en-US, so instead just do what iOS > does and copy ui_test.pak to en.lproj/locale.pak and roll it into the > mini-framework bundle. > > BUG=410468 > > Committed: https://crrev.com/bac8fafd3d056f1277c2fdf44d2a66ca19252e54 > Cr-Commit-Position: refs/heads/master@{#294052} TBR=avi@chromium.org NOTREECHECKS=true NOTRY=true BUG=410468 Committed: https://crrev.com/adfa5731821d44c3e6e1704e156e61cff089b58f Cr-Commit-Position: refs/heads/master@{#294321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M ui/base/ui_base_tests_bundle.gypi View 2 chunks +3 lines, -4 lines 0 comments Download
M ui/resources/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/resources/ui_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tapted
Created Revert of Simplify test locales in ui_unittests Framework
6 years, 3 months ago (2014-09-11 05:18:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560993004/1
6 years, 3 months ago (2014-09-11 05:19:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as d634d9506dc7f1ba7cdf372d936b86b222cb8d56
6 years, 3 months ago (2014-09-11 05:21:58 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 05:24:47 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/adfa5731821d44c3e6e1704e156e61cff089b58f
Cr-Commit-Position: refs/heads/master@{#294321}

Powered by Google App Engine
This is Rietveld 408576698