Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 560993002: remove c++11 enum scope in ServiceWorkerRegistration::OnRestoreFinished (Closed)

Created:
6 years, 3 months ago by Mostyn Bramley-Moore
Modified:
6 years, 3 months ago
Reviewers:
michaeln, falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

remove c++11 enum scope in ServiceWorkerRegistration::OnRestoreFinished Followup to CL 506043002: remove unneeded c++11 enum scope for consistency (and since we haven't officially switched to c++11 yet). BUG=398355 Committed: https://crrev.com/36e00d9f13a77da9d30e6df5923335529f16f34f Cr-Commit-Position: refs/heads/master@{#294311}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/service_worker/service_worker_registration.cc View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 10 (4 generated)
Mostyn Bramley-Moore
@michaeln: does this tiny fixup look OK?
6 years, 3 months ago (2014-09-10 21:42:01 UTC) #2
michaeln
https://codereview.chromium.org/560993002/diff/1/content/browser/service_worker/service_worker_registration.cc File content/browser/service_worker/service_worker_registration.cc (right): https://codereview.chromium.org/560993002/diff/1/content/browser/service_worker/service_worker_registration.cc#newcode325 content/browser/service_worker/service_worker_registration.cc:325: callback.Run(SERVICE_WORKER_ERROR_ABORT); lgtm, thnx
6 years, 3 months ago (2014-09-10 22:36:57 UTC) #3
Mostyn Bramley-Moore
https://codereview.chromium.org/560993002/diff/1/content/browser/service_worker/service_worker_registration.cc File content/browser/service_worker/service_worker_registration.cc (right): https://codereview.chromium.org/560993002/diff/1/content/browser/service_worker/service_worker_registration.cc#newcode325 content/browser/service_worker/service_worker_registration.cc:325: callback.Run(SERVICE_WORKER_ERROR_ABORT); On 2014/09/10 22:36:57, michaeln wrote: > lgtm, thnx ...
6 years, 3 months ago (2014-09-10 23:13:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560993002/1
6 years, 3 months ago (2014-09-10 23:18:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5fbdea848820a6d1bd4324e5fccfebfee24d71c2
6 years, 3 months ago (2014-09-11 03:25:31 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 03:36:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36e00d9f13a77da9d30e6df5923335529f16f34f
Cr-Commit-Position: refs/heads/master@{#294311}

Powered by Google App Engine
This is Rietveld 408576698