Add private extension API to move the accessibility focus ring.

chrome/browser/accessibility/accessibility_extension_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/accessibility/accessibility_extension_api.h"
 
 #include "base/json/json_writer.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/accessibility/accessibility_extension_api_constants.h"
 #include "chrome/browser/extensions/api/tabs/tabs_constants.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_tab_util.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/extensions/api/accessibility_private.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "components/infobars/core/confirm_infobar_delegate.h"
 #include "components/infobars/core/infobar.h"
 #include "content/public/browser/browser_accessibility_state.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/browser/extension_host.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/lazy_background_task_queue.h"
 #include "extensions/common/error_utils.h"
 #include "extensions/common/manifest_handlers/background_info.h"
 
+#if defined(OS_CHROMEOS)

[David Tseng, 2014/09/10 22:50:28]

Are we going to be able to support all platforms? If so, add a todo here. If
not, then we should chat about ChromeVox next functionality tradeoffs on
non-CROS.

[dmazzoni, 2014/09/11 22:04:36]

Implementing this on other platforms is possible but nontrivial. As we discussed
offline, we're going to implement this on Chrome OS only for now while ChromeVox
Next is still under development. As we get closer to release we can decide
whether we want to port something similar or implement an alternative.

+#include "chrome/browser/chromeos/ui/accessibility_focus_ring_controller.h"
+#endif
+
 namespace keys = extension_accessibility_api_constants;
 namespace accessibility_private = extensions::api::accessibility_private;
 
 // Returns the AccessibilityControlInfo serialized into a JSON string,
 // consisting of an array of a single object of type AccessibilityObject,
 // as defined in the accessibility extension api's json schema.
 scoped_ptr<base::ListValue> ControlInfoToEventArguments(
     const AccessibilityEventInfo* info) {
   base::DictionaryValue* dict = new base::DictionaryValue();
   info->SerializeToDict(dict);
@@ skipping 263 matching lines @@
       const base::string16 message_text =
           confirm_infobar_delegate->GetMessageText();
       alert_value->SetString(keys::kMessageKey, message_text);
       alerts_value->Append(alert_value);
     }
   }
 
   SetResult(alerts_value);
   return true;
 }
+
+bool AccessibilityPrivateSetFocusRingFunction::RunSync() {
+#if defined(OS_CHROMEOS)
+  base::ListValue* rect_values = NULL;
+  EXTENSION_FUNCTION_VALIDATE(args_->GetList(0, &rect_values));
+
+  std::vector<gfx::Rect> rects;
+  for (size_t i = 0; i < rect_values->GetSize(); ++i) {
+    base::DictionaryValue* rect_value = NULL;
+    EXTENSION_FUNCTION_VALIDATE(rect_values->GetDictionary(i, &rect_value));
+    int left, top, width, height;
+    EXTENSION_FUNCTION_VALIDATE(rect_value->GetInteger("left", &left));
+    EXTENSION_FUNCTION_VALIDATE(rect_value->GetInteger("top", &top));
+    EXTENSION_FUNCTION_VALIDATE(rect_value->GetInteger("width", &width));
+    EXTENSION_FUNCTION_VALIDATE(rect_value->GetInteger("height", &height));
+    rects.push_back(gfx::Rect(left, top, width, height));
+  }

[David Tseng, 2014/09/10 22:50:28]

I'd check to make sure the auto-generated api bindings doesn't already do all
this for you in some |Parse| method. I know in an idl specified api, it does.

[dmazzoni, 2014/09/11 22:04:36]

Sure. I filed http://crbug.com/413421 and I'm happy to start on that now in
parallel. I'll merge either way depending on what change happens first.

+
+  chromeos::AccessibilityFocusRingController::GetInstance()->SetFocusRing(
+      rects);
+#endif  // defined(OS_CHROMEOS)

[David Tseng, 2014/09/10 22:50:28]

Should fail on other platforms.

[dmazzoni, 2014/09/11 22:04:36]

Done.

+
+  return true;
+}