Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 560923002: Remove DesktopBrowserBackend.SetProfileDir since it's deadcode. (Closed)

Created:
6 years, 3 months ago by nednguyen
Modified:
6 years, 3 months ago
Reviewers:
tonyg, chrishenry
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove DesktopBrowserBackend.SetProfileDir since it's deadcode. BUG= Committed: https://crrev.com/2ab903f7671ca80c798088c9d41ae5597257b450 Cr-Commit-Position: refs/heads/master@{#294261}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py View 3 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
nednguyen
6 years, 3 months ago (2014-09-10 22:03:09 UTC) #2
tonyg
lgtm
6 years, 3 months ago (2014-09-10 22:04:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/560923002/1
6 years, 3 months ago (2014-09-10 22:15:54 UTC) #5
chrishenry
lgtm
6 years, 3 months ago (2014-09-10 23:38:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as ffcb8543689101b03e1b4ebf93c90fea6641faf5
6 years, 3 months ago (2014-09-10 23:47:24 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 00:05:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ab903f7671ca80c798088c9d41ae5597257b450
Cr-Commit-Position: refs/heads/master@{#294261}

Powered by Google App Engine
This is Rietveld 408576698