Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 560913004: Revert of Mac: Fix rounded corners on browser windows on retina display. (Closed)

Created:
6 years, 3 months ago by erikchen
Modified:
6 years, 3 months ago
CC:
chromium-reviews, ccameron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Mac: Fix rounded corners on browser windows on retina display. (patchset #4 id:80001 of https://codereview.chromium.org/463263002/) Reason for revert: When the download bar is present, the rounded corners are on the wrong view. https://code.google.com/p/chromium/issues/detail?id=412580 Original issue's description: > Mac: Fix rounded corners on browser windows on retina display. > > When a window's bottom corner is covered by a layer on a retina display, the > corner is incorrectly rounded. I added a layer mask to do the corner rounding > ourselves. > > BUG=396264 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289811 TBR=andresantoso@chromium.org,ccameron@chromium.org,shess@chromium.org NOTREECHECKS=true NOTRY=true BUG=396264 Committed: https://crrev.com/4e8a29255097ef8757b2bde0d8777625265355d8 Cr-Commit-Position: refs/heads/master@{#294265}

Patch Set 1 #

Patch Set 2 : Merge conflicts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -114 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller_private.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/fast_resize_view.h View 1 1 chunk +1 line, -13 lines 0 comments Download
M chrome/browser/ui/cocoa/fast_resize_view.mm View 1 3 chunks +0 lines, -92 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
erikchen
Created Revert of Mac: Fix rounded corners on browser windows on retina display.
6 years, 3 months ago (2014-09-10 20:29:16 UTC) #1
Andre
lgtm
6 years, 3 months ago (2014-09-10 20:33:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/560913004/1
6 years, 3 months ago (2014-09-10 21:02:21 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/cocoa/browser_window_controller_private.mm: While running git apply --index -p1; error: patch failed: ...
6 years, 3 months ago (2014-09-10 21:11:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560913004/150001
6 years, 3 months ago (2014-09-10 23:49:55 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:150001) as ec787cead58de666c44e21e3a045d73fd6381d0f
6 years, 3 months ago (2014-09-10 23:56:57 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 00:09:13 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4e8a29255097ef8757b2bde0d8777625265355d8
Cr-Commit-Position: refs/heads/master@{#294265}

Powered by Google App Engine
This is Rietveld 408576698