Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: pkg/analysis_server/test/services/correction/assist_test.dart

Issue 560913003: Issue 20890. Fix for NPE in the 'Add show' QA. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/assist_internal.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/correction/assist_test.dart
diff --git a/pkg/analysis_server/test/services/correction/assist_test.dart b/pkg/analysis_server/test/services/correction/assist_test.dart
index 3648e73680175fd11b47cb85a5ddec8bc075de71..b4a7c9db099f8fbe783a7b2fe81aee2b2159e311 100644
--- a/pkg/analysis_server/test/services/correction/assist_test.dart
+++ b/pkg/analysis_server/test/services/correction/assist_test.dart
@@ -911,6 +911,23 @@ import 'dart:math';
assertNoAssistAt('import ', AssistKind.IMPORT_ADD_SHOW);
}
+ void test_importAddShow_OK_hasUnresolvedIdentifier() {
+ _indexTestUnit('''
+import 'dart:math';
+main(x) {
+ PI;
+ return x.foo();
+}
+''');
+ assertHasAssistAt('import ', AssistKind.IMPORT_ADD_SHOW, '''
+import 'dart:math' show PI;
+main(x) {
+ PI;
+ return x.foo();
+}
+''');
+ }
+
void test_importAddShow_OK_onDirective() {
_indexTestUnit('''
import 'dart:math';
« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/assist_internal.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698