Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1689)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

Issue 560893005: First checked-in import of the W3C's test suites. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: add new expectations for newly failing w3c tests Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py b/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
index b5d4cce27c8d5b33c1ca1a3a9811b38f2f6aa9d0..b8405f3d84fc54ed767669bde2143d72325850a4 100644
--- a/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
+++ b/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
@@ -312,6 +312,9 @@ class Manager(object):
if self._options.show_results and (exit_code or (self._options.full_results_html and initial_results.total_failures)):
self._port.show_results_html_file(results_path)
self._printer.print_results(time.time() - start_time, initial_results, summarized_failing_results)
+
+ self._check_for_stale_w3c_dir()
+
return test_run_results.RunDetails(exit_code, summarized_full_results, summarized_failing_results, initial_results, retry_results, enabled_pixel_tests_in_retry)
def _run_tests(self, tests_to_run, tests_to_skip, repeat_each, iterations, num_workers, retrying):
@@ -354,6 +357,14 @@ class Manager(object):
_log.debug("Cleaning up port")
self._port.clean_up_test_run()
+ def _check_for_stale_w3c_dir(self):
+ # TODO(dpranke): Remove this check after 1/1/2015 and let people deal with the warnings.
+ # Remove the check in port/base.py as well.
+ fs = self._port.host.filesystem
+ layout_tests_dir = self._port.layout_tests_dir()
+ if fs.isdir(fs.join(layout_tests_dir, 'w3c')):
+ _log.warning('WARNING: You still have the old LayoutTests/w3c directory in your checkout. You should delete it!')
+
def _force_pixel_tests_if_needed(self):
if self._options.pixel_tests:
return False
« no previous file with comments | « LayoutTests/imported/web-platform-tests/webrtc/simplecall.html ('k') | Tools/Scripts/webkitpy/layout_tests/port/base.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698