tools/gn/function_read_file.cc - Issue 560883003: Cleanup: Use base/files/file_util.h instead of base/file_util.h in [r-t]*/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/gn/function_read_file.cc

Issue 560883003: Cleanup: Use base/files/file_util.h instead of base/file_util.h in [r-t]*/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/gn/function_exec_script.cc ('k') | tools/gn/function_write_file.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/file_util.h"	5 #include "base/files/file_util.h"

6 #include "tools/gn/err.h"	6 #include "tools/gn/err.h"

7 #include "tools/gn/filesystem_utils.h"	7 #include "tools/gn/filesystem_utils.h"

8 #include "tools/gn/functions.h"	8 #include "tools/gn/functions.h"

9 #include "tools/gn/input_conversion.h"	9 #include "tools/gn/input_conversion.h"

10 #include "tools/gn/input_file.h"	10 #include "tools/gn/input_file.h"

11 #include "tools/gn/scheduler.h"	11 #include "tools/gn/scheduler.h"

12	12

13 // TODO(brettw) consider removing this. I originally wrote it for making the	13 // TODO(brettw) consider removing this. I originally wrote it for making the

14 // WebKit bindings but misundersood what was required, and didn't need to	14 // WebKit bindings but misundersood what was required, and didn't need to

15 // use this. This seems to have a high potential for misuse.	15 // use this. This seems to have a high potential for misuse.

(...skipping 50 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
66 *err = Err(args[0], "Could not read file.",	66 *err = Err(args[0], "Could not read file.",

67 "I resolved this to \"" + FilePathToUTF8(file_path) + "\".");	67 "I resolved this to \"" + FilePathToUTF8(file_path) + "\".");

68 return Value();	68 return Value();

69 }	69 }

70	70

71 return ConvertInputToValue(scope->settings(), file_contents, function,	71 return ConvertInputToValue(scope->settings(), file_contents, function,

72 args[1], err);	72 args[1], err);

73 }	73 }

74	74

75 } // namespace functions	75 } // namespace functions

OLD	NEW